Project

General

Profile

Actions

Bug #2662

closed

Failed puppet run: undefined method `escape_for_shell' for Proxy::Puppet:Module

Added by Ivan Necas about 11 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

$subject$ when trying to puppetrun via smart-proxy.

Changing:

def self.escape_for_shell(command)

to

def escape_for_shell(command)

Seems to work. I wonder, if there is a context where the original code works as well?

Actions #1

Updated by Dominic Cleal about 11 years ago

  • Priority changed from Normal to Urgent
  • Target version set to 1.2.0

Which version of the proxy is this?

This code was added in 216728d09495fe5a2940760df702910642853bca, so perhaps you're seeing it there. It seems I added a regression when merging 80f8a61f43504ec3a4753dda2ef201483e5ce855 though, which relocated the content and was written before the first fix.

I think we need to put the escape_for_shell code back, and make sure we don't hit this error again?

Actions #2

Updated by Ivan Necas about 11 years ago

I'm running my custom build based on aff8fa8b4f7108b30c3e2ff6ec9068c9851e4d91, it seems the recent git doesn't have the problem, but I agree that escape_for_shell was there for a reason, so it should get back.

Thanks for REALLY quick response :)

Actions #3

Updated by Anonymous about 11 years ago

Ivan - do you have a backtrace for this? Looks like Proxy::Util.escape_for_shell is not being used anywhere in smart-proxy/devel...

Actions #4

Updated by Dominic Cleal about 11 years ago

Dmitri Dolguikh wrote:

Ivan - do you have a backtrace for this? Looks like Proxy::Util.escape_for_shell is not being used anywhere in smart-proxy/devel...

See the above comments, I accidentally removed the code in the second SHA above. This issue now becomes: please restore 216728d09495fe5a2940760df702910642853bca but without the undefined method bug :)

Actions #5

Updated by Anonymous about 11 years ago

  • Status changed from New to Assigned
  • Assignee set to Anonymous
Actions #6

Updated by Anonymous about 11 years ago

  • Status changed from Assigned to Ready For Testing
Actions #7

Updated by Anonymous about 11 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #8

Updated by Greg Sutcliffe almost 6 years ago

  • Target version deleted (1.2.0)
Actions

Also available in: Atom PDF