Failed puppet run: undefined method `escape_for_shell' for Proxy::Puppet:Module
$subject$ when trying to puppetrun via smart-proxy.
Seems to work. I wonder, if there is a context where the original code works as well?
fixes #2662 - Proxy::Util.escape_for_shell is being used in PuppetRun.run and MCollective.run methods
#1 Updated by Dominic Cleal over 7 years ago
- Priority changed from Normal to Urgent
- Target version set to 1.2.0
Which version of the proxy is this?
This code was added in 216728d09495fe5a2940760df702910642853bca, so perhaps you're seeing it there. It seems I added a regression when merging 80f8a61f43504ec3a4753dda2ef201483e5ce855 though, which relocated the content and was written before the first fix.
I think we need to put the escape_for_shell code back, and make sure we don't hit this error again?
#4 Updated by Dominic Cleal over 7 years ago
Dmitri Dolguikh wrote:
Ivan - do you have a backtrace for this? Looks like Proxy::Util.escape_for_shell is not being used anywhere in smart-proxy/devel...
See the above comments, I accidentally removed the code in the second SHA above. This issue now becomes: please restore 216728d09495fe5a2940760df702910642853bca but without the undefined method bug :)