Project

General

Profile

Bug #26642

Proxy tracking breaks POST data

Added by Lukas Zapletal 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Category:
Core
Target version:
-
Difficulty:
trivial
Triaged:
Yes
Bugzilla link:

Description

My work and Ivan's review in smart proxy dynflow core revealed nasty bug in our logging stack in smart proxy. This luckily only hits when FOREMAN_PROXY_TRACE env variable is set to true which is only for debugging purposes. Rack input (StringIO) is read however it is never rewinded back, therefore later on the data is empty therefore POST/PUT services do not work correctly. Additionally, time tracking code can lead to nil error during exceptions.

Associated revisions

Revision 8546c29d (diff)
Added by Lukas Zapletal 6 months ago

Fixes #26642 - logging post data fix

Revision 6dedd0fc (diff)
Added by Ewoud Kohl van Wijngaarden 5 months ago

Refs #26642 - Correct path logging

In 8546c29d0a9af9de7653b80e22a6afc7b7b5ef89 the 'Started' log line
started to use REQUEST_PATH. This completes it by also logging the
'Finished' line with a matching path.

History

#1 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/647 added

#2 Updated by Michael Moll 6 months ago

  • Fixed in Releases 1.23.0 added

#3 Updated by Anonymous 6 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot 5 months ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/651 added

Also available in: Atom PDF