Bug #26642: Proxy tracking breaks POST data - Smart Proxy - Foreman

Actions

Copy link

Bug #26642

closed

Proxy tracking breaks POST data

Added by Lukas Zapletal almost 6 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Lukas Zapletal

Category:

Core

Target version:

Difficulty:

trivial

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/theforeman/smart-proxy/pull/647, https://github.com/theforeman/smart-proxy/pull/651

Fixed in Releases:

Foreman - 1.23.0

Found in Releases:

Red Hat JIRA:

Description

My work and Ivan's review in smart proxy dynflow core revealed nasty bug in our logging stack in smart proxy. This luckily only hits when FOREMAN_PROXY_TRACE env variable is set to true which is only for debugging purposes. Rack input (StringIO) is read however it is never rewinded back, therefore later on the data is empty therefore POST/PUT services do not work correctly. Additionally, time tracking code can lead to nil error during exceptions.