Bug #26656
closed
Display memory in consistent way
Description
Based on the feedback from the mailing list:
Can you explain why one VM showed 1024Mi where others showed 1Gi for the memory? It looked like it came straight from the API since the console also showed 1Gi where Foreman normally uses GB.
We need to make sure to always use GB while displaying virtual machine memory.
---
There is inconsistency in the reported memory - we should normalize it to a single units:
2.3.3 :016 > c.servers.map { |s| s.memory }
=> ["1Gi", "1024Mi", "1024Mi", "1024M"]
So we got Gi, Mi and M - but that doesn't contradict:
https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/#meaning-of-memory
However, can fractions be specified ? Assuming user would like less than 1G vm ?
We faced similar issue with MIQ kubevirt provider here:
https://github.com/ManageIQ/manageiq-providers-kubevirt/blob/master/app/models/manageiq/providers/kubevirt/memory_calculator.rb#L31
Updated by
Updated by Moti Asayag almost 5 years ago
- Status changed from New to Assigned
- Assignee changed from Shira Maximov to Moti Asayag
Updated by Moti Asayag almost 5 years ago
- Difficulty changed from easy to medium
Updated by Moti Asayag almost 5 years ago
- Pull request https://github.com/theforeman/foreman_kubevirt/pull/100 added
Updated by Moti Asayag almost 5 years ago
- Status changed from Assigned to Ready For Testing
Updated by Moti Asayag almost 5 years ago
We'll align the presented units reported by KubeVirt to the same method presented size in foreman (using number_to_human_size), so the units will be unified with other providers and foreman memory presentation (MB or GB).
Updated by Moti Asayag almost 5 years ago
- Status changed from Ready For Testing to Closed