Project

General

Custom queries

Profile

Actions
Copy link

Bug #26656

closed

Display memory in consistent way

Added by Moti Asayag almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Moti Asayag
Target version:
-
Difficulty:
medium
Triaged:
Yes
Bugzilla link:
1702228
Pull request:
https://github.com/theforeman/foreman_kubevirt/pull/100
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Based on the feedback from the mailing list:

Can you explain why one VM showed 1024Mi where others showed 1Gi for the memory?
It looked like it came straight from the API since the console also showed 1Gi where Foreman normally uses GB.

We need to make sure to always use GB while displaying virtual machine memory.
---
There is inconsistency in the reported memory - we should normalize it to a single units:


2.3.3 :016 > c.servers.map { |s| s.memory }
=> ["1Gi", "1024Mi", "1024Mi", "1024M"]

So we got Gi, Mi and M - but that doesn't contradict:
https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/#meaning-of-memory

However, can fractions be specified ? Assuming user would like less than 1G vm ?
We faced similar issue with MIQ kubevirt provider here:
https://github.com/ManageIQ/manageiq-providers-kubevirt/blob/master/app/models/manageiq/providers/kubevirt/memory_calculator.rb#L31

Added by Moti Asayag almost 6 years ago

Revision 163415ae (diff)

Fixes #26656 - Fix memory issues (#100)

The PR fixes few memory issues:
  • The memory default value should be a string (same as passed in
    arguments)
  • Memory default value should be provided as string (this is the
    expected format in the VM arguments)
  • Tests should be updated no to provide memory or CPU in order to rely
    on the defaults
  • Memory should be shown in a normalized way in the UI
  • When creating VM, the memory should be converted to MB, while before
    this PR it was considered to be MiB which lead to a lower amount of
    memory than expected.
Actions
Copy link

Also available in: Atom PDF