Project

General

Profile

Actions

Bug #26676

closed

Setting initialization is very inefficient and generates a lot of SQL queries

Added by Marek Hulán about 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Settings
Target version:
-
Fixed in Releases:
Found in Releases:

Description

If you load the application with sql logger enabled, you can see hundreds of queries against Settings table. Nearly all of them are unnecessary, there are multiple problems.

1) we update the setting even if it's definition didn't change (twice)
2) we load every setting individually
3) we check if settings table exists by loading one setting object


Related issues 7 (0 open7 closed)

Precedes foreman-tasks - Bug #27815: Setting initialization improvementClosedOndřej EzrActions
Precedes Ansible - Refactor #27816: Setting initialization improvementClosedOndřej EzrActions
Precedes Foreman Remote Execution - Refactor #27818: Setting initialization improvementClosedOndřej EzrActions
Precedes Boot disk - Refactor #27819: Setting initialization improvementClosedOndřej EzrActions
Precedes Chef - Refactor #27820: Setting initialization improvementClosedOndřej EzrActions
Precedes Salt - Refactor #27821: Setting initialization improvementClosedOndřej EzrActions
Precedes Katello - Refactor #27863: Setting initialization improvementClosedOndřej EzrActions
Actions #1

Updated by The Foreman Bot about 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6708 added
Actions #2

Updated by Marek Hulán about 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #3

Updated by Lukas Zapletal about 5 years ago

  • Status changed from Closed to New
Actions #4

Updated by The Foreman Bot about 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6737 added
Actions #5

Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6902 added
Actions #6

Updated by The Foreman Bot almost 5 years ago

  • Fixed in Releases 1.24.0 added
Actions #7

Updated by Marek Hulán almost 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #8

Updated by Ondřej Ezr almost 5 years ago

  • Precedes Bug #27815: Setting initialization improvement added
Actions #9

Updated by Ondřej Ezr almost 5 years ago

Actions #10

Updated by Ondřej Ezr almost 5 years ago

Actions #11

Updated by Ondřej Ezr almost 5 years ago

Actions #12

Updated by Ondřej Ezr almost 5 years ago

Actions #13

Updated by Ondřej Ezr almost 5 years ago

Actions #14

Updated by Ondřej Ezr almost 5 years ago

Actions #15

Updated by Tomer Brisker over 4 years ago

  • Subject changed from Setting intialization is very inneficient and generates a lot of SQL queries to Setting initialization is very inefficient and generates a lot of SQL queries
Actions

Also available in: Atom PDF