Project

General

Profile

Bug #26676

Setting initialization is very inefficient and generates a lot of SQL queries

Added by Marek Hulán over 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Settings
Target version:
-

Description

If you load the application with sql logger enabled, you can see hundreds of queries against Settings table. Nearly all of them are unnecessary, there are multiple problems.

1) we update the setting even if it's definition didn't change (twice)
2) we load every setting individually
3) we check if settings table exists by loading one setting object


Related issues

Precedes foreman-tasks - Bug #27815: Setting initialization improvementClosed
Precedes Ansible - Refactor #27816: Setting initialization improvementClosed
Precedes Foreman Remote Execution - Refactor #27818: Setting initialization improvementClosed
Precedes Boot disk - Refactor #27819: Setting initialization improvementClosed
Precedes Chef - Refactor #27820: Setting initialization improvementClosed
Precedes Salt - Refactor #27821: Setting initialization improvementClosed
Precedes Katello - Refactor #27863: Setting initialization improvementClosed

Associated revisions

Revision 18020cc6 (diff)
Added by Marek Hulán over 1 year ago

Fixes #26676 - improve setting initialization

Revision b90f0979 (diff)
Added by Marek Hulán about 1 year ago

Fixes #26676 - improve setting initialization

History

#1 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6708 added

#2 Updated by Marek Hulán over 1 year ago

  • Status changed from Ready For Testing to Closed

#3 Updated by Lukas Zapletal over 1 year ago

  • Status changed from Closed to New

#4 Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/6737 added

#5 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6902 added

#6 Updated by The Foreman Bot about 1 year ago

  • Fixed in Releases 1.24.0 added

#7 Updated by Marek Hulán about 1 year ago

  • Status changed from Ready For Testing to Closed

#8 Updated by Ondřej Ezr about 1 year ago

  • Precedes Bug #27815: Setting initialization improvement added

#9 Updated by Ondřej Ezr about 1 year ago

#10 Updated by Ondřej Ezr about 1 year ago

#11 Updated by Ondřej Ezr about 1 year ago

#12 Updated by Ondřej Ezr about 1 year ago

#13 Updated by Ondřej Ezr about 1 year ago

#14 Updated by Ondřej Ezr about 1 year ago

#15 Updated by Tomer Brisker 12 months ago

  • Subject changed from Setting intialization is very inneficient and generates a lot of SQL queries to Setting initialization is very inefficient and generates a lot of SQL queries

Also available in: Atom PDF