Project

General

Profile

Actions
Copy link

Bug #26676

closed

Setting initialization is very inefficient and generates a lot of SQL queries

Added by Marek Hulán over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marek Hulán
Category:
Settings
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/6708, https://github.com/theforeman/foreman/pull/6737, https://github.com/theforeman/foreman/pull/6902
Fixed in Releases:
1.24.0
Found in Releases:
Red Hat JIRA:

Description

If you load the application with sql logger enabled, you can see hundreds of queries against Settings table. Nearly all of them are unnecessary, there are multiple problems.

1) we update the setting even if it's definition didn't change (twice)
2) we load every setting individually
3) we check if settings table exists by loading one setting object

Related issues 7 (0 open — 7 closed)

Precedes foreman-tasks - Bug #27815: Setting initialization improvementClosedOndřej EzrActions
Precedes Ansible - Refactor #27816: Setting initialization improvementClosedOndřej EzrActions
Precedes Foreman Remote Execution - Refactor #27818: Setting initialization improvementClosedOndřej EzrActions
Precedes Boot disk - Refactor #27819: Setting initialization improvementClosedOndřej EzrActions
Precedes Chef - Refactor #27820: Setting initialization improvementClosedOndřej EzrActions
Precedes Salt - Refactor #27821: Setting initialization improvementClosedOndřej EzrActions
Precedes Katello - Refactor #27863: Setting initialization improvementClosedOndřej EzrActions
Actions
Copy link
 #1

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6708 added
Actions
Copy link
 #2

Updated by Marek Hulán over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #3

Updated by Lukas Zapletal over 5 years ago

  • Status changed from Closed to New
Actions
Copy link
 #4

Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6737 added
Actions
Copy link
 #5

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6902 added
Actions
Copy link
 #6

Updated by The Foreman Bot over 5 years ago

  • Fixed in Releases 1.24.0 added
Actions
Copy link
 #7

Updated by Marek Hulán over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #8

Updated by Ondřej Ezr over 5 years ago

  • Precedes Bug #27815: Setting initialization improvement added
Actions
Copy link
 #9

Updated by Ondřej Ezr over 5 years ago

Actions
Copy link
 #10

Updated by Ondřej Ezr over 5 years ago

Actions
Copy link
 #11

Updated by Ondřej Ezr over 5 years ago

Actions
Copy link
 #12

Updated by Ondřej Ezr over 5 years ago

Actions
Copy link
 #13

Updated by Ondřej Ezr over 5 years ago

Actions
Copy link
 #14

Updated by Ondřej Ezr over 5 years ago

Actions
Copy link
 #15

Updated by Tomer Brisker about 5 years ago

  • Subject changed from Setting intialization is very inneficient and generates a lot of SQL queries to Setting initialization is very inefficient and generates a lot of SQL queries
Actions
Copy link

Also available in: Atom PDF