Project

General

Profile

Actions

Bug #26702

closed

Inconsistent naming of the --upgrade-mongo-storage-engine flag

Added by Evgeni Golov about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
foreman-installer script
Target version:
Difficulty:
trivial
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

The flag is called --upgrade-mongo-storage-engine, but the installer sometimes forgets the -engine:

% git grep mongo-storage
katello/hooks/boot/21-mongo_storage_engine.rb:  '--upgrade-mongo-storage-engine',
katello/hooks/pre/30-upgrade.rb:      logger.info 'To upgrade to WiredTiger at a later time run foreman-installer with the --upgrade-mongo-storage flag.'
katello/hooks/pre/30-upgrade.rb:        f << "# Added by foreman-installer during upgrade, run the installer with --upgrade-mongo-storage to upgrade to WiredTiger.\n" 
katello/hooks/pre/31-mongo_storage_engine.rb:  Kafo::Helpers.execute("sed -i -e 's/Added by foreman-installer during upgrade, run the installer with --upgrade-mongo-storage to upgrade to WiredTiger./Do not remove'/g #{hiera_file}")
katello/hooks/pre_validations/30-mongo_storage_engine.rb:    fail_and_exit 'Concurrent use of --upgrade and --upgrade-mongo-storage-engine is not supported. '\
katello/hooks/pre_validations/30-mongo_storage_engine.rb:                  'Please run --upgrade first, then --upgrade-mongo-storage-engine.'

Related issues 1 (0 open1 closed)

Related to Installer - Bug #27866: MongoDB storage engine upgrade does not properly update the hiera comment in all casesClosedEvgeni GolovActions
Actions #1

Updated by The Foreman Bot about 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-installer/pull/349 added
Actions #2

Updated by Ewoud Kohl van Wijngaarden about 5 years ago

  • Category set to foreman-installer script
  • Target version set to 1.23.0
  • Triaged changed from No to Yes
  • Fixed in Releases 1.23.0 added

Should this be cherry picked into 1.22 now that it's still RC?

Actions #3

Updated by Evgeni Golov about 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by Evgeni Golov about 5 years ago

  • Bugzilla link set to 1704806
Actions #5

Updated by Evgeni Golov almost 5 years ago

  • Related to Bug #27866: MongoDB storage engine upgrade does not properly update the hiera comment in all cases added
Actions

Also available in: Atom PDF