Project

General

Profile

Feature #26709

Rethink TFTP naming conventions for PXE files

Added by Lukas Zapletal over 1 year ago. Updated 5 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
TFTP
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

The new naming convention implemented in #19389 is not good, while it workarounds concurrency problems it creates unecessary amount of files. Here is how we could implement this:

  • we can keep the current unique id approach in core (in Katello lets change from DBID to URL hash like in core)
  • new code in proxy
  • before anything is downloaded, do HTTP HEAD and acquire last-modified/etag sha1 hash
  • then download the content to a filename SHA1 (or skip if the file already exists)
  • then create a relative symlink FilenameFromForemanCore-XYZ -> SHA
  • extend TFTP API with "expiration" flag - every created symlink would have expiration time, this would be stored as FILENAME.expire_at timestamp or text file
* expiration is set by Foreman core according to Token expiration (when it expires TFTP files are actually also invalid) - when set to zero no expiration is performed * change back naming convention sent from foreman to Operating Sytem, Architecture and Version (https://community.theforeman.org/t/pxe-files-kernel-initrd/15354) * there will be a cronjob running every day cleaning up expired symlinks * the cronjob can optionally delete SHA1 named (content) files which are "orphans" (have zero symlinks) and are older than 1 year

We can also use hardlinks instead of symlinks.

Problems:

  • Foreman can download from any mirror, not all mirrors provide etag/last-modified. In that case, we'd need to redownload every time.

Related issues

Related to Foreman - Feature #19389: Change TFTP filename pattern to include unique installation media IDClosed
Related to Foreman - Bug #28965: Regression: Since #19389 boot image of debian is not updated and installation is brokenClosed

History

#1 Updated by Lukas Zapletal over 1 year ago

  • Tracker changed from Bug to Feature

#2 Updated by Lukas Zapletal over 1 year ago

  • Related to Feature #19389: Change TFTP filename pattern to include unique installation media ID added

#3 Updated by The Foreman Bot over 1 year ago

  • Assignee set to Lukas Zapletal
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6726 added

#4 Updated by Lukas Zapletal about 1 year ago

  • Assignee deleted (Lukas Zapletal)
  • Status changed from Ready For Testing to New
  • Description updated (diff)
  • Pull request deleted (https://github.com/theforeman/foreman/pull/6726)

#5 Updated by Lukas Zapletal about 1 year ago

  • Subject changed from Perform HTTP HEAD prior downloading kernel/initramdisk to Rethink TFTP naming conventions for PXE files

#6 Updated by Lukas Zapletal about 1 year ago

  • Description updated (diff)

#7 Updated by Daniel Kraemer 8 months ago

  • Related to Bug #28965: Regression: Since #19389 boot image of debian is not updated and installation is broken added

#8 Updated by Lukas Zapletal 5 months ago

  • Description updated (diff)

Also available in: Atom PDF