Feature #2675: Metrics in summary email should be sorted - Foreman

Actions

Copy link

Feature #2675

closed

Metrics in summary email should be sorted

Added by Dirk Melchers over 11 years ago. Updated almost 9 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Category:

Reporting

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

The metrics in the daily summary mail are not sorted and change order every day, which is confusing.

My ruby knowledge is zero - but the attached patch seems to fix it.

Please review and fix - I am very unsure, if the second sort will work correctly...

Regards,

Dirk.

Files

_active_hosts.html.erb.patch

938 Bytes

Dirk Melchers, 06/18/2013 04:05 AM

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by Dominic Cleal over 11 years ago

Status changed from New to Ready For Testing
Target version set to 1.3.0

Actions

Copy link

Updated by Dominic Cleal over 11 years ago

Thanks for the patch Dirk. If you're comfortable with git, please submit it as a pull request to our GitHub repo, but if not hopefully somebody can do this on your behalf and double check it.

Actions

Copy link

Updated by Dirk Melchers over 11 years ago

Dominic Cleal wrote:

Thanks for the patch Dirk. If you're comfortable with git, please submit it as a pull request to our GitHub repo, but if not hopefully somebody can do this on your behalf and double check it.

I would prefer if someone else could do this - because someone who knows ruby and .erb-files has to check it again!

Actions

Copy link