Project

General

Profile

Actions

Feature #2675

closed

Metrics in summary email should be sorted

Added by Dirk Melchers almost 11 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Reporting
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The metrics in the daily summary mail are not sorted and change order every day, which is confusing.

My ruby knowledge is zero - but the attached patch seems to fix it.

Please review and fix - I am very unsure, if the second sort will work correctly...

Regards,

Dirk.


Files

_active_hosts.html.erb.patch _active_hosts.html.erb.patch 938 Bytes Dirk Melchers, 06/18/2013 04:05 AM

Related issues 1 (1 open0 closed)

Related to Foreman - Tracker #7585: Mail notifications trackerNew

Actions
Actions #1

Updated by Dominic Cleal almost 11 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 1.3.0
Actions #2

Updated by Dominic Cleal almost 11 years ago

Thanks for the patch Dirk. If you're comfortable with git, please submit it as a pull request to our GitHub repo, but if not hopefully somebody can do this on your behalf and double check it.

Actions #3

Updated by Dirk Melchers almost 11 years ago

Dominic Cleal wrote:

Thanks for the patch Dirk. If you're comfortable with git, please submit it as a pull request to our GitHub repo, but if not hopefully somebody can do this on your behalf and double check it.

I would prefer if someone else could do this - because someone who knows ruby and .erb-files has to check it again!

Actions #4

Updated by Lukas Zapletal over 10 years ago

  • Description updated (diff)
  • Target version deleted (1.3.0)
Actions #5

Updated by Stephen Benjamin over 9 years ago

Actions #6

Updated by Amir Fefer about 8 years ago

  • Status changed from Ready For Testing to Resolved

Metrics in summary email already sorted, as you can see here:
https://github.com/theforeman/foreman/blob/develop/app/mailers/host_mailer.rb#L11

Actions

Also available in: Atom PDF