Project

General

Profile

Actions

Bug #26756

closed

Drop invalid scsi_controller_type attribute

Added by Ondřej Ezr almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Compute resources - VMware
Target version:
-
Fixed in Releases:
Found in Releases:

Description

In the #26402 we started to pass the attribute instead of ignoring it.
But now if someone had an old hammer command working, with invalid type of the `scsi_controller_type`, the command will fail on new version.

For not breaking old hammer commands, which dropped the attribute altogether, I would like to drop invalid values for this attribute.

Better solution would be validate and give the user meaningful feedback, but it is out of scope and would not reach the same version as the fix.


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #26402: vmware compute-attributes scsi_controller_type not honoredClosedOndřej EzrActions
Actions #1

Updated by Ondřej Ezr almost 5 years ago

  • Related to Bug #26402: vmware compute-attributes scsi_controller_type not honored added
Actions #2

Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6744 added
Actions #3

Updated by Marek Hulán almost 5 years ago

  • Fixed in Releases 1.23.0 added
Actions #4

Updated by Marek Hulán almost 5 years ago

  • Bugzilla link set to 1707298
Actions #5

Updated by Ondřej Ezr almost 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #6

Updated by The Foreman Bot almost 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6800 added
Actions #7

Updated by Tomer Brisker almost 5 years ago

  • Fixed in Releases 1.22.0 added
  • Fixed in Releases deleted (1.23.0)
Actions

Also available in: Atom PDF