Project

General

Profile

Bug #26756

Drop invalid scsi_controller_type attribute

Added by Ondřej Ezr about 2 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Compute resources - VMware
Target version:
-
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

In the #26402 we started to pass the attribute instead of ignoring it.
But now if someone had an old hammer command working, with invalid type of the `scsi_controller_type`, the command will fail on new version.

For not breaking old hammer commands, which dropped the attribute altogether, I would like to drop invalid values for this attribute.

Better solution would be validate and give the user meaningful feedback, but it is out of scope and would not reach the same version as the fix.


Related issues

Related to Foreman - Bug #26402: vmware compute-attributes scsi_controller_type not honoredClosed

Associated revisions

Revision a317b6eb (diff)
Added by Ondřej Ezr about 2 months ago

Fixes #26756 - drop invalid values for scsi_controller_type (#6744)

History

#1 Updated by Ondřej Ezr about 2 months ago

  • Related to Bug #26402: vmware compute-attributes scsi_controller_type not honored added

#2 Updated by The Foreman Bot about 2 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6744 added

#3 Updated by Marek Hulán about 2 months ago

  • Fixed in Releases 1.23.0 added

#4 Updated by Marek Hulán about 2 months ago

  • Bugzilla link set to 1707298

#5 Updated by Ondřej Ezr about 2 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by The Foreman Bot about 1 month ago

  • Pull request https://github.com/theforeman/foreman/pull/6800 added

#7 Updated by Tomer Brisker about 1 month ago

  • Fixed in Releases 1.22.0 added
  • Fixed in Releases deleted (1.23.0)

Also available in: Atom PDF