Bug #26830: Redux-form 8 is incompatible with react-redux 5 - Foreman

Actions

Copy link

Bug #26830

closed

Redux-form 8 is incompatible with react-redux 5

Added by Tomer Brisker over 5 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Avi Sharvit

Category:

JavaScript stack

Target version:

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/6773

Fixed in Releases:

1.23.0

Found in Releases:

Red Hat JIRA:

Description

We need to either downgrade redux-form or upgrade react-redux. This is currently breaking nightly builds.
Not sure why this only breaks in production and not in development.
see https://github.com/erikras/redux-form/issues/4388

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Tomer Brisker over 5 years ago

Related to Refactor #26723: Bump redux-form version added

Actions

Copy link

Updated by Ohad Levy over 5 years ago

Not sure why this only breaks in production and not in development.

this infact only breaks packaged based rpm, it does work fine on npm based production.

Actions

Copy link

Updated by Tomer Brisker over 5 years ago

I'd say the fact it works in npm based install is actually the problem, since the two versions are in fact incompatible and we should have caught this in development rather than only after rpms are built.

Actions

Copy link

Updated by Tomer Brisker over 5 years ago

npm based install has react-redux 5.1.1 while packaged version is 5.0.7. when running `npm install react-redux@5.0.7` the same error is present in development as well.

Actions

Copy link

Updated by Ohad Levy over 5 years ago

Tomer Brisker wrote:

npm based install has react-redux 5.1.1 while packaged version is 5.0.7. when running `npm install react-redux@5.0.7` the same error is present in development as well.

I wonder whats the difference than, as I have npm install the project (from clean env) and the bookmark form functionality does work as expected...

Actions

Copy link