Bug #26830
closed
Redux-form 8 is incompatible with react-redux 5
Description
We need to either downgrade redux-form or upgrade react-redux. This is currently breaking nightly builds.
Not sure why this only breaks in production and not in development.
see https://github.com/erikras/redux-form/issues/4388
Updated by Tomer Brisker almost 6 years ago
- Related to Refactor #26723: Bump redux-form version added
Updated by Ohad Levy almost 6 years ago
Not sure why this only breaks in production and not in development.
this infact only breaks packaged based rpm, it does work fine on npm based production.
Updated by Tomer Brisker almost 6 years ago
I'd say the fact it works in npm based install is actually the problem, since the two versions are in fact incompatible and we should have caught this in development rather than only after rpms are built.
Updated by Tomer Brisker almost 6 years ago
npm based install has react-redux 5.1.1 while packaged version is 5.0.7. when running `npm install react-redux@5.0.7` the same error is present in development as well.
Updated by Ohad Levy almost 6 years ago
Tomer Brisker wrote:
npm based install has react-redux 5.1.1 while packaged version is 5.0.7. when running `npm install react-redux@5.0.7` the same error is present in development as well.
I wonder whats the difference than, as I have npm install the project (from clean env) and the bookmark form functionality does work as expected...
Updated by Tomer Brisker almost 6 years ago
react-redux 5.1 seems to be compatible - https://github.com/reduxjs/react-redux/commit/1b43eaa86d89144bfe2ef72db095f69bf7944cf2#diff-4a561361865a8e6d0758088bf7cded8dR92 is the change that prevents this failure.
Updated by The Foreman Bot almost 6 years ago
- Status changed from New to Ready For Testing
- Assignee set to Avi Sharvit
- Pull request https://github.com/theforeman/foreman/pull/6773 added
Updated by Ewoud Kohl van Wijngaarden almost 6 years ago
- Triaged changed from No to Yes
- Fixed in Releases 1.23.0 added
Updated by Avi Sharvit almost 6 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset aa73237c92c89346bba5e57e6357b1c2008bdb24.