Project

General

Profile

Actions

Bug #26830

closed

Redux-form 8 is incompatible with react-redux 5

Added by Tomer Brisker almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

We need to either downgrade redux-form or upgrade react-redux. This is currently breaking nightly builds.
Not sure why this only breaks in production and not in development.
see https://github.com/erikras/redux-form/issues/4388


Related issues 1 (0 open1 closed)

Related to Foreman - Refactor #26723: Bump redux-form versionClosedOndřej PražákActions
Actions #1

Updated by Tomer Brisker almost 5 years ago

Actions #2

Updated by Ohad Levy almost 5 years ago

Not sure why this only breaks in production and not in development.


this infact only breaks packaged based rpm, it does work fine on npm based production.
Actions #3

Updated by Tomer Brisker almost 5 years ago

I'd say the fact it works in npm based install is actually the problem, since the two versions are in fact incompatible and we should have caught this in development rather than only after rpms are built.

Actions #4

Updated by Tomer Brisker almost 5 years ago

npm based install has react-redux 5.1.1 while packaged version is 5.0.7. when running `npm install ` the same error is present in development as well.

Actions #5

Updated by Ohad Levy almost 5 years ago

Tomer Brisker wrote:

npm based install has react-redux 5.1.1 while packaged version is 5.0.7. when running `npm install ` the same error is present in development as well.

I wonder whats the difference than, as I have npm install the project (from clean env) and the bookmark form functionality does work as expected...

Actions #6

Updated by Tomer Brisker almost 5 years ago

Actions #7

Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Avi Sharvit
  • Pull request https://github.com/theforeman/foreman/pull/6773 added
Actions #8

Updated by Ewoud Kohl van Wijngaarden almost 5 years ago

  • Triaged changed from No to Yes
  • Fixed in Releases 1.23.0 added
Actions #9

Updated by Avi Sharvit almost 5 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF