Project

General

Profile

Bug #26830

Redux-form 8 is incompatible with react-redux 5

Added by Tomer Brisker 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

We need to either downgrade redux-form or upgrade react-redux. This is currently breaking nightly builds.
Not sure why this only breaks in production and not in development.
see https://github.com/erikras/redux-form/issues/4388


Related issues

Related to Foreman - Refactor #26723: Bump redux-form versionClosed

Associated revisions

Revision aa73237c (diff)
Added by Avi Sharvit 7 months ago

Fixes #26830 - upgrade react-redux to v5.1.1

History

#1 Updated by Tomer Brisker 7 months ago

#2 Updated by Ohad Levy 7 months ago

Not sure why this only breaks in production and not in development.


this infact only breaks packaged based rpm, it does work fine on npm based production.

#3 Updated by Tomer Brisker 7 months ago

I'd say the fact it works in npm based install is actually the problem, since the two versions are in fact incompatible and we should have caught this in development rather than only after rpms are built.

#4 Updated by Tomer Brisker 7 months ago

npm based install has react-redux 5.1.1 while packaged version is 5.0.7. when running `npm install ` the same error is present in development as well.

#5 Updated by Ohad Levy 7 months ago

Tomer Brisker wrote:

npm based install has react-redux 5.1.1 while packaged version is 5.0.7. when running `npm install ` the same error is present in development as well.

I wonder whats the difference than, as I have npm install the project (from clean env) and the bookmark form functionality does work as expected...

#6 Updated by Tomer Brisker 7 months ago

#7 Updated by The Foreman Bot 7 months ago

  • Assignee set to Avi Sharvit
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6773 added

#8 Updated by Ewoud Kohl van Wijngaarden 7 months ago

  • Triaged changed from No to Yes
  • Fixed in Releases 1.23.0 added

#9 Updated by Avi Sharvit 7 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF