Project

General

Profile

Actions
Copy link

Bug #26861

open

Make less props required for "EmptyState" component

Added by John Mitsch almost 5 years ago. Updated almost 5 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

On Katello's ModuleStream page, we are getting quite a few warnings when there is no data for the table:

checkPropTypes.js:20 Warning: Failed prop type: The prop `description` is marked as required in `DefaultEmptyState`, but its value is `undefined`.

checkPropTypes.js:20 Warning: Failed prop type: The prop `description` is marked as required in `EmptyStatePattern`, but its value is `undefined`.

checkPropTypes.js:20 Warning: Failed prop type: The prop `children` is marked as required in `EmptyStateInfo`, but its value is `undefined`.

It would be nice if EmptyState didn't have so many required props, and instead, let you just pass a 'header' to it to display when there are no results.

Actions
Copy link
 #1

Updated by John Mitsch almost 5 years ago

  • Description updated (diff)
Actions
Copy link

Also available in: Atom PDF