Project

General

Profile

Actions

Bug #26957

closed

Foreman sends session instead request as X-Request-Id

Added by Lukas Zapletal over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Logging
Target version:
-
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

We send the data to correlate logs but instead request we send session id. This is confusing, I am going to actually send both.

Edit: Also, second part of the problem is that we send session id, which could be vulnerable to session hijacking. We must only send logging_token which is a randomly generated token stored in the session. -- this is actually not true, session mdc field is not vulnerable.


Related issues 1 (0 open1 closed)

Related to Smart Proxy - Bug #26962: Send also session id to structured logsClosedLukas ZapletalActions
Actions #1

Updated by Lukas Zapletal over 5 years ago

  • Description updated (diff)
Actions #2

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6827 added
Actions #3

Updated by Lukas Zapletal over 5 years ago

  • Related to Bug #26962: Send also session id to structured logs added
Actions #4

Updated by Tomer Brisker over 5 years ago

  • Fixed in Releases 1.22.1, 1.23.0 added
Actions #5

Updated by Lukas Zapletal over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF