Bug #26961: Field filtering (--fileds option) prints more fields then requested - Hammer CLI - Foreman

Actions

Copy link

Bug #26961

closed

Field filtering (--fileds option) prints more fields then requested

Added by Martin Bacovsky over 5 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Martin Bacovsky

Category:

Hammer core

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/hammer-cli/pull/307

Team Backlog:

Fixed in Releases:

Found in Releases:

In Kanboard:

Red Hat JIRA:

Description

Currently fields prints all fields that start with the field in the list. I like the possibilities this opens but would prefer it to be rather opt-in.

Current state:

hammer host info --id 4 --fields network
Network:            
    IPv4 address: 192.168.121.172
    MAC:          52:54:00:c8:6b:01
    Subnet ipv4:  pichi.example.com
    Domain:       pichi.example.com
Network interfaces: 
 1) Id:           4
    Identifier:   eth0
    Type:         interface (primary, provision)
    MAC address:  52:54:00:c8:6b:01
    IPv4 address: 192.168.121.172
    FQDN:         centos7.pichi.example.com

I would expect only "Network" to be printed as it is what I asked for. Possibility to have 'hammer host info --id 4 --fields network*' for what we see today would be nice and useful.

Actions

Copy link

Updated by Martin Bacovsky over 5 years ago

One more issue was detected - when no --fields is provided filter by sets is ignored. It results in situation when if some fields are in 'ALL' set and not in the DEFAULT one they are printed when no --fields is used. Id expect such fields to be printed only when --fields ALL is explicitly used.

Actions

Copy link