Project

General

Profile

Bug #2697

Daily Summary is broken

Added by Ryan Davies almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Reporting
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

rdavies@uss-enterprise:/usr/share/foreman$ sudo -u foreman RAILS_ENV=production /usr/bin/ruby193-rake reports:summarize
rake aborted!
undefined method `deliver_summary' for HostMailer:Class

Tasks: TOP => reports:summarize
(See full trace by running task with --trace)

Associated revisions

Revision 7ff08812 (diff)
Added by Joseph Magen almost 6 years ago

fixes #2697 - HostMailer summary is broken
(cherry picked from commit 8e851ef524a3348c1587e53e3c2da616fdbe1fdc)

Revision 0a932172 (diff)
Added by Joseph Magen almost 6 years ago

fixes #2697 again - HostMailer typo and .deliver

Revision 0b91a274 (diff)
Added by Joseph Magen almost 6 years ago

fixes #2697 again - HostMailer typo and .deliver
(cherry picked from commit 0a93217273d8b41f4d1d91e29c2be9c4547c90d3)

Revision ea09f443 (diff)
Added by Joseph Magen almost 6 years ago

fixes #2697 - HostMailer summary is broken
(cherry picked from commit 8e851ef524a3348c1587e53e3c2da616fdbe1fdc)
(cherry picked from commit 7ff08812e42c2688a995caca60ad236e67a2814e)

History

#1 Updated by Ryan Davies almost 6 years ago

Again with trace option

rdavies@uss-enterprise:/usr/share/foreman$ sudo -u foreman RAILS_ENV=production /usr/bin/ruby193-rake reports:summarize --trace
  • Invoke reports:summarize (first_time)
  • Invoke environment (first_time)
  • Execute environment
  • Execute reports:summarize
    rake aborted!
    undefined method `deliver_summary' for HostMailer:Class
    /opt/rh/ruby193/root/usr/share/gems/gems/actionmailer-3.2.8/lib/action_mailer/base.rb:438:in `method_missing'
    /usr/share/foreman/lib/tasks/reports.rake:80:in `block (2 levels) in <top (required)>'
    /opt/rh/ruby193/root/usr/share/ruby/rake/task.rb:205:in `call'
    /opt/rh/ruby193/root/usr/share/ruby/rake/task.rb:205:in `block in execute'
    /opt/rh/ruby193/root/usr/share/ruby/rake/task.rb:200:in `each'
    /opt/rh/ruby193/root/usr/share/ruby/rake/task.rb:200:in `execute'
    /opt/rh/ruby193/root/usr/share/ruby/rake/task.rb:158:in `block in invoke_with_call_chain'
    /opt/rh/ruby193/root/usr/share/ruby/monitor.rb:211:in `mon_synchronize'
    /opt/rh/ruby193/root/usr/share/ruby/rake/task.rb:151:in `invoke_with_call_chain'
    /opt/rh/ruby193/root/usr/share/ruby/rake/task.rb:144:in `invoke'
    /opt/rh/ruby193/root/usr/share/ruby/rake/application.rb:116:in `invoke_task'
    /opt/rh/ruby193/root/usr/share/ruby/rake/application.rb:94:in `block (2 levels) in top_level'
    /opt/rh/ruby193/root/usr/share/ruby/rake/application.rb:94:in `each'
    /opt/rh/ruby193/root/usr/share/ruby/rake/application.rb:94:in `block in top_level'
    /opt/rh/ruby193/root/usr/share/ruby/rake/application.rb:133:in `standard_exception_handling'
    /opt/rh/ruby193/root/usr/share/ruby/rake/application.rb:88:in `top_level'
    /opt/rh/ruby193/root/usr/share/ruby/rake/application.rb:66:in `block in run'
    /opt/rh/ruby193/root/usr/share/ruby/rake/application.rb:133:in `standard_exception_handling'
    /opt/rh/ruby193/root/usr/share/ruby/rake/application.rb:63:in `run'
    /opt/rh/ruby193/root/usr/bin/rake:32:in `<main>'
    Tasks: TOP => reports:summarize

#2 Updated by Joseph Magen almost 6 years ago

I don't see the method deliver_summary in the HostMailer class???

#3 Updated by Dominic Cleal almost 6 years ago

Joseph Magen wrote:

I don't see the method deliver_summary in the HostMailer class???

I think this might be a 3.0->3.2 change, was it handled by method_missing in ActionMailer::Base before? Looks like it should be HostMailer.summary(options).deliver perhaps now.

#4 Updated by Joseph Magen almost 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Joseph Magen

#5 Updated by Joseph Magen almost 6 years ago

  • Status changed from Assigned to Ready For Testing

good call Dominic. I should have seen thought :-)

https://github.com/theforeman/foreman/pull/737

#6 Updated by Joseph Magen almost 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF