Project

General

Profile

Refactor #26974

Remove hardcoded open timeout for Smart Proxy RestClient

Added by Lukas Zapletal almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
Smart Proxy
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/6829
Fixed in Releases:
1.24.0
Found in Releases:
Red Hat JIRA:

Description

We hardcode it to 10 seconds but timeout (read timeout) is configurable. This is confusing, let's drop the hardcoded value so "timeout" setting will set all three timeouts at once:

https://github.com/rest-client/rest-client#timeouts

Also this patch adds a note about hammer.

Associated revisions

Revision 9e7bec56 (diff)
Added by Lukas Zapletal over 3 years ago

Fixes #26974 - removed hardcoded timeout

History

#1 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6829 added

#2 Updated by The Foreman Bot over 3 years ago

  • Fixed in Releases 1.24.0 added

#3 Updated by Lukas Zapletal over 3 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF