Project

General

Custom queries

Profile

Actions
Copy link

Bug #27195

open

Plugin stylesheet bundles contain styles from core

Added by Ondřej Pražák about 6 years ago. Updated over 5 years ago.

Status:
Ready For Testing
Priority:
Normal
Assignee:
Avi Sharvit
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/7233, https://github.com/theforeman/foreman/pull/7320
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

When inspecting plugin stylesheet bundles in production, they contain styles from core even though plugin does not use them and does not import them.

Steps to reproduce:
1) Go to page that uses plugin stylesheets from webpack (Hosts -> New with foreman_ansible plugin, Monitor -> Tasks)
2) Inspect the source of the css bundle

In development, the styles are pulled in as well, but it is more difficult to see as developer tools will point directly to the file from core.

Files

foreman-tasks-bundle.png View foreman-tasks-bundle.png 227 KB Ondřej Pražák, 07/01/2019 01:30 PM
foreman-ansible-bundle.png View foreman-ansible-bundle.png 269 KB Ondřej Pražák, 07/01/2019 01:30 PM
production-pointing-to-bundle.png View production-pointing-to-bundle.png 300 KB Ondřej Pražák, 07/01/2019 01:38 PM
development-pointing-to-file-in-core.png View development-pointing-to-file-in-core.png 268 KB Ondřej Pražák, 07/01/2019 01:38 PM
Webpack-Bundle-Analyzer.png View Webpack-Bundle-Analyzer.png 433 KB webpack analyze results Avi Sharvit, 07/02/2019 07:21 AM

Related issues 2 (0 open — 2 closed)

Related to Foreman - Refactor #27172: Do not use !important in layout stylesheetsClosedOndřej PražákActions
Related to Foreman - Bug #33153: Slot registry isn't singleton ClosedAmir FeferActions
Actions
Copy link
 #1

Updated by Ondřej Pražák about 6 years ago

  • Related to Refactor #27172: Do not use !important in layout stylesheets added
Actions
Copy link
 #2

Updated by Avi Sharvit about 6 years ago

Same is true for `js` bundles.
A copy of the core javascript gets copied into each plugin js bundle.
  • Only happen if the plugins use the `componentRegistrt`
Actions
Copy link
 #3

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Avi Sharvit
  • Pull request https://github.com/theforeman/foreman/pull/7233 added
Actions
Copy link
 #4

Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/7320 added
Actions
Copy link
 #5

Updated by Amir Fefer almost 4 years ago

  • Related to Bug #33153: Slot registry isn't singleton added
Actions
Copy link

Also available in: Atom PDF