Project

General

Profile

Bug #27269

Capsules upgraded from Katello 2.x wrongly use no_prefix=true in the installer

Added by Evgeni Golov 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
foreman-installer script
Target version:
-
Difficulty:
easy
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Katello Capsules (Content Proxies) before Katello 3.0 had no_prefix: true in their Installer config (see https://github.com/Katello/katello-installer/blob/KATELLO-2.4/config/capsule-installer.yaml#L5 vs https://github.com/Katello/katello-installer/blob/KATELLO-3.0/config/capsule.yaml#L7) because the installer was quite different back then.

However, this option was never properly migrated to false on upgrades from 2.x to 3.0 (or later), resulting in Capsules that would have their Installer options being prefix-less.

As you usually don't need to pass many options to the installer when you upgrade, this went largely unnoticed until now when we renamed the certs-tar-file option in Foreman 1.22/Katello 3.12 which broke upgrades that would regenerate the certs tarball on each upgrade (this is not required, but should work).

Associated revisions

Revision 5ab9f797 (diff)
Added by Evgeni Golov 5 months ago

Fixes #27269 - force no_prefix to the default for f-proxy-content

Katello Capsules (Content Proxies) before Katello 3.0 had no_prefix: true in
their Installer config because the installer was quite different back then.

However, this option was never properly migrated to false on upgrades from
2.x to 3.0 (or later), resulting in Capsules that would have their Installer
options being prefix-less.

As you usually don't need to pass many options to the installer when you
upgrade, this went largely unnoticed until now when we renamed the
certs-tar-file option in Foreman 1.22/Katello 3.12 which broke upgrades
that would regenerate the certs tarball on each upgrade
(this is not required, but should work).

This change force no_prefix to the default (false) on content proxies,
thus finally fixing this issue.

History

#1 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-installer/pull/372 added

#2 Updated by Ewoud Kohl van Wijngaarden 5 months ago

  • Category set to foreman-installer script
  • Fixed in Releases 1.23.0 added

#3 Updated by Evgeni Golov 5 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF