Bug #27335: Using a dynamic :controller segment in a route is deprecated in Rails 6.0 - Discovery - Foreman

Actions

Copy link

Bug #27335

closed

Using a dynamic :controller segment in a route is deprecated in Rails 6.0

Added by Lukas Zapletal almost 6 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Lukas Zapletal

Category:

Discovery plugin

Target version:

Discovery Plugin 16.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman_discovery/pull/481

Fixed in Releases:

Discovery Plugin 16.0

Found in Releases:

Red Hat JIRA:

Description

I have never understood how this "help" pages work. In discovery plugin I have a welcome.html.erb view that renders "No discovered hosts found in this context" page when there are no records and this has been working fine for years.

This suggested patch adds ability to use /discovered_hosts/help URL which was previously not working, but I don't believe there is any link in the discovery plugin to this URL. So I am not sure how useful the route is.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Lukas Zapletal almost 6 years ago

Related to Refactor #23191: Using a dynamic :controller segment in a route is deprecated in Rails 6.0 added

Actions

Copy link

Updated by The Foreman Bot almost 6 years ago

Status changed from New to Ready For Testing
Assignee set to Lukas Zapletal
Pull request https://github.com/theforeman/foreman_discovery/pull/481 added