Project

General

Profile

Bug #27335

Using a dynamic :controller segment in a route is deprecated in Rails 6.0

Added by Lukas Zapletal almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
Discovery plugin
Target version:
Discovery Plugin 16.0
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_discovery/pull/481
Fixed in Releases:
Discovery Plugin 16.0
Found in Releases:

Description

I have never understood how this "help" pages work. In discovery plugin I have a welcome.html.erb view that renders "No discovered hosts found in this context" page when there are no records and this has been working fine for years.

This suggested patch adds ability to use /discovered_hosts/help URL which was previously not working, but I don't believe there is any link in the discovery plugin to this URL. So I am not sure how useful the route is.

Related issues

Related to Foreman - Refactor #23191: Using a dynamic :controller segment in a route is deprecated in Rails 6.0Closed

Associated revisions

Revision 178e4d4e (diff)
Added by Lukas Zapletal over 2 years ago

Fixes #27335 - getting rid of Rails 6 incomp

And improve discover script

History

#1 Updated by Lukas Zapletal almost 3 years ago

  • Related to Refactor #23191: Using a dynamic :controller segment in a route is deprecated in Rails 6.0 added

#2 Updated by The Foreman Bot almost 3 years ago

  • Assignee set to Lukas Zapletal
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_discovery/pull/481 added

#3 Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases Discovery Plugin 16.0 added

#4 Updated by Anonymous over 2 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF