Project

General

Profile

Actions

Bug #27559

closed

"Log in" button on login screen used to have 'name="commit"` and new version of login form do not have it

Added by Jan Hutař over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Satellite 6.6 have login button like this:

<input type="submit" name="commit" value="Log In" class="btn btn-primary" data-disable-with="Log In">

New form have:

<button type="submit" disabled="" class="login-pf-submit-button btn btn-lg btn-primary btn-block">Log In</button>

QE UI automation is using that:

https://github.com/SatelliteQE/airgun/blob/f40612c431dc3e2d01bf95b0c04d4bcabd90f316/airgun/views/login.py#L7

Would it be possible to put "name=" back or add "id=" (generally, QE would like to have ID on every functional form component)?


Related issues 1 (0 open1 closed)

Related to Foreman - Feature #24990: Move LoginPage into a React component using patternfly-react LoginPage component.ClosedRon LaviActions
Actions #1

Updated by Jan Hutař over 4 years ago

  • Subject changed from "Log in" button on login screen used to have 'name="commit"` and new version of login for do not have it to "Log in" button on login screen used to have 'name="commit"` and new version of login form do not have it
Actions #2

Updated by Marek Hulán over 4 years ago

That's since it's no longer rendered using rails helpers. Would some unique id help or is the name important attribute for the automation? This was probably introduced by https://github.com/theforeman/foreman/pull/6234

Actions #3

Updated by Marek Hulán over 4 years ago

  • Related to Feature #24990: Move LoginPage into a React component using patternfly-react LoginPage component. added
Actions #4

Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6971 added
Actions #5

Updated by The Foreman Bot over 4 years ago

  • Fixed in Releases 1.24.0 added
Actions #6

Updated by Ron Lavi over 4 years ago

  • Status changed from Ready For Testing to Closed
Actions #7

Updated by Amit Upadhye over 4 years ago

  • Category set to JavaScript stack
Actions

Also available in: Atom PDF