Project

General

Profile

Bug #27559

"Log in" button on login screen used to have 'name="commit"` and new version of login form do not have it

Added by Jan Hutař 5 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Satellite 6.6 have login button like this:

<input type="submit" name="commit" value="Log In" class="btn btn-primary" data-disable-with="Log In">

New form have:

<button type="submit" disabled="" class="login-pf-submit-button btn btn-lg btn-primary btn-block">Log In</button>

QE UI automation is using that:

https://github.com/SatelliteQE/airgun/blob/f40612c431dc3e2d01bf95b0c04d4bcabd90f316/airgun/views/login.py#L7

Would it be possible to put "name=" back or add "id=" (generally, QE would like to have ID on every functional form component)?


Related issues

Related to Foreman - Feature #24990: Move LoginPage into a React component using patternfly-react LoginPage component.Closed

Associated revisions

Revision 8fe3f5d4 (diff)
Added by Ron Lavi 4 months ago

Fixes #27559 - match old login page button attr

History

#1 Updated by Jan Hutař 5 months ago

  • Subject changed from "Log in" button on login screen used to have 'name="commit"` and new version of login for do not have it to "Log in" button on login screen used to have 'name="commit"` and new version of login form do not have it

#2 Updated by Marek Hulán 5 months ago

That's since it's no longer rendered using rails helpers. Would some unique id help or is the name important attribute for the automation? This was probably introduced by https://github.com/theforeman/foreman/pull/6234

#3 Updated by Marek Hulán 5 months ago

  • Related to Feature #24990: Move LoginPage into a React component using patternfly-react LoginPage component. added

#4 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6971 added

#5 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 1.24.0 added

#6 Updated by Ron Lavi 4 months ago

  • Status changed from Ready For Testing to Closed

#7 Updated by Amit Upadhye 3 months ago

  • Category set to JavaScript stack

Also available in: Atom PDF