Bug #27559: "Log in" button on login screen used to have 'name="commit"` and new version of login form do not have it - Foreman

Bug #27559

"Log in" button on login screen used to have 'name="commit"` and new version of login form do not have it

Added by Jan Hutař over 3 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

JavaScript stack

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/6971

Fixed in Releases:

1.24.0

Found in Releases:

Red Hat JIRA:

Description

Satellite 6.6 have login button like this:

<input type="submit" name="commit" value="Log In" class="btn btn-primary" data-disable-with="Log In">

New form have:

<button type="submit" disabled="" class="login-pf-submit-button btn btn-lg btn-primary btn-block">Log In</button>

QE UI automation is using that:

https://github.com/SatelliteQE/airgun/blob/f40612c431dc3e2d01bf95b0c04d4bcabd90f316/airgun/views/login.py#L7

Would it be possible to put "name=" back or add "id=" (generally, QE would like to have ID on every functional form component)?

Related issues

Associated revisions

Revision 8fe3f5d4 (diff)
Added by Ron Lavi over 3 years ago

Fixes #27559 - match old login page button attr

History

#1 Updated by Jan Hutař over 3 years ago

Subject changed from "Log in" button on login screen used to have 'name="commit"` and new version of login for do not have it to "Log in" button on login screen used to have 'name="commit"` and new version of login form do not have it

#2 Updated by Marek Hulán over 3 years ago

That's since it's no longer rendered using rails helpers. Would some unique id help or is the name important attribute for the automation? This was probably introduced by https://github.com/theforeman/foreman/pull/6234