Bug #27654: Expose http(s) port number setting via httpboot plugin - Smart Proxy - Foreman

Bug #27654

Expose http(s) port number setting via httpboot plugin

Added by Lukas Zapletal almost 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Lukas Zapletal

Category:

HTTPBoot

Target version:

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/theforeman/smart-proxy/pull/679, https://github.com/theforeman/smart-proxy/pull/677, https://github.com/theforeman/smart-proxy/pull/676

Fixed in Releases:

Foreman - 1.24.0

Found in Releases:

Description

Foreman core needs this to setup boot URL correctly.

Related issues

Associated revisions

Revision e344672b (diff)
Added by Lukas Zapletal almost 3 years ago

Fixes #27654 - expose http(s) port setting

Revision f88b53d6 (diff)
Added by Ewoud Kohl van Wijngaarden almost 3 years ago

Refs #27654 - Move HTTP enabled logic to plugin settings

This introduces simple helpers to be used elsewhere. The Plugin Settings
class makes more sense for this since it's specific to a plugin setting.

Revision 79ce65f7 (diff)
Added by Ewoud Kohl van Wijngaarden almost 3 years ago

Refs #27654 - Account for module enabled over http or not

The module can be enabled for http-only while the proxy is https-only
(or other combinations). This patch takes the enabled setting into
account and guarantees that the http_port is only set when the module is
actually available over http. The same goes for https_port.