Project

General

Profile

Bug #27681

rest-client 2.1.0 breaks tests

Added by Tomer Brisker 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

RuntimeError: unknown RestClient::Response.create version (2.1.0, arity -4)
test/active_support_test_case_helper.rb:225:in `fake_rest_client_response'
test/unit/proxy_api/bmc_test.rb:101:in `block in <class:ProxyApiBmcTest>' (RuntimeError)
/home/jenkins/workspace/test_develop_pr_core/database/postgresql/ruby/2.3/slave/fast/test/active_support_test_case_helper.rb:225


Related issues

Related to Foreman - Refactor #15573: Support rest-client 2.0.0Closed2016-07-04

Associated revisions

Revision 42cf34e6 (diff)
Added by Tomer Brisker 3 months ago

Fixes #27681 - Fix test for rest-client 2.1 support

The arity of Response.create funciton changed in 2.1, causing an old
workaround to allow working with bot 1.8 and 2.x to fail. Since we
require >2.0 now there is no more need for the check for older versions.

History

#1 Updated by Tomer Brisker 3 months ago

https://github.com/rest-client/rest-client/commit/de5e2685fda0daebb0049a14cd296c9785186d58 changed the arity of the create method, causing the check in the test helper to fail.

#2 Updated by Tomer Brisker 3 months ago

#3 Updated by The Foreman Bot 3 months ago

  • Assignee set to Tomer Brisker
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6994 added

#4 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 1.24.0 added

#5 Updated by Tomer Brisker 3 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by Tomer Brisker 3 months ago

  • Fixed in Releases 1.21.4, 1.22.1, 1.23.0 added
  • Fixed in Releases deleted (1.24.0)

Also available in: Atom PDF