Bug #27719: Adding a 2nd disk type of storage_pod/datastore_cluster fails to create vm - Foreman

Bug #27719

Adding a 2nd disk type of storage_pod/datastore_cluster fails to create vm

Added by Chris Roberts over 3 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ondřej Ezr

Category:

Compute resources - VMware

Target version:

1.23.1

Difficulty:

easy

Triaged:

Yes

Bugzilla link:

1746175

Pull request:

https://github.com/theforeman/foreman/pull/7213, https://github.com/theforeman/foreman/pull/7004

Fixed in Releases:

1.24.0

Found in Releases:

1.23.0

Red Hat JIRA:

Description

Error:

Failed to create a compute test (VMware) instance tammy-arnzen.toledo.satellite.lab.eng.rdu2.redhat.com: wrong number of arguments (given 2, expected 1)

Traceback:

```ruby
2019-08-27T16:40:18 [W|app|09a39f98] Failed to create a compute test (VMware) instance tammy-arnzen.toledo.satellite.lab.eng.rdu2.redhat.com: wrong number of arguments (given 2, expected 1)

ArgumentError: wrong number of arguments (given 2, expected 1)
/opt/theforeman/tfm/root/usr/share/gems/gems/fog-vsphere-3.2.0/lib/fog/vsphere/requests/compute/create_vm.rb:75:in `group_disks_by_storage_pod'
/opt/theforeman/tfm/root/usr/share/gems/gems/fog-vsphere-3.2.0/lib/fog/vsphere/requests/compute/create_vm.rb:55:in `create_vm_on_storage_pod'
/opt/theforeman/tfm/root/usr/share/gems/gems/fog-vsphere-3.2.0/lib/fog/vsphere/requests/compute/create_vm.rb:36:in `create_vm'
/opt/theforeman/tfm/root/usr/share/gems/gems/fog-vsphere-3.2.0/lib/fog/vsphere/models/compute/server.rb:302:in `save'
/usr/share/foreman/app/models/compute_resources/foreman/model/vmware.rb:484:in `create_vm'
/usr/share/foreman/app/models/concerns/orchestration/compute.rb:91:in `setCompute'

```

disks.png

View disks.png

80.5 KB

Chris Roberts, 08/27/2019 08:47 PM

Associated revisions

Revision 6c6e15da (diff)
Added by Ondřej Ezr over 3 years ago

Fixes #27719 - bumb fog-vsphere

Revision 8a6f9023 (diff)
Added by Ewoud Kohl van Wijngaarden over 3 years ago

Refs #27719 - Specify the fog-vsphere dep clearer

Our gem to RPM dependency converter is not that smart and has a too
verbose output. Before this change:

Requires: %{?scl_prefix}rubygem(fog-vsphere) >= 3.2
Requires: %{?scl_prefix}rubygem(fog-vsphere) < 4.0
Requires: %{?scl_prefix}rubygem(fog-vsphere) >= 3.2.1

After:

Requires: %{?scl_prefix}rubygem(fog-vsphere) >= 3.2.1
Requires: %{?scl_prefix}rubygem(fog-vsphere) < 4.0