Project

General

Profile

Actions

Refactor #27763

closed

remove redundant url_for

Added by Amir Fefer almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

when `url_for` gets a string it returns the same string

url_for(compute_resource_path(@compute_resource))

equals to:

compute_resource_path(@compute_resource)

therefore there are few cases that url_for is redundant.

Actions #1

Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7015 added
Actions #2

Updated by The Foreman Bot almost 5 years ago

  • Fixed in Releases 1.24.0 added
Actions #3

Updated by Amir Fefer almost 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by Tomer Brisker almost 5 years ago

  • Category set to Rails
  • Fixed in Releases deleted (1.24.0)
Actions #5

Updated by Tomer Brisker almost 5 years ago

  • Fixed in Releases 1.24.0 added
Actions

Also available in: Atom PDF