Project

General

Profile

Feature #27794

Create basic ForemanModal component and Storybook

Added by Jeremy Lenz about 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
medium
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Create a React modal component based on Patternfly React 4. It will be reusable across Foreman and plugins, and will support the upcoming UI team work around the Host creation wizard.

Associated revisions

Revision 7c240321 (diff)
Added by Jeremy Lenz 12 months ago

Fixes #27794: Add ForemanModal

add basic ForemanModal component based on patternfly-react Modal
wip composable header/footers
separate out Header and Footer subcomponents
add Hooks and Context to pass data to subcomponents
add several Storybook stories
move aside outside the Modal
add new story for props
refactor after laviro review
allow modal hide using props instead of not rendering
Add snapshot tests
fix linter i hope
more refactor after review
Add unit tests
add close button tests
switch from lodash omit to native JS
extract extractModalNodes to helper function
Don't pass title prop as it causes unwanted tooltip
rename file to ForemanModalHooks.js
update import
move useModalState to stories
use arrow function over regular function
fix lint issue
add esdoc comments to helper
add test for helper
extract context into its own file to avoid circular imports

remove title from PropTypes
update snapshots
fix linter

History

#1 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/7039 added

#2 Updated by The Foreman Bot about 1 year ago

  • Status changed from New to Ready For Testing

#3 Updated by The Foreman Bot 12 months ago

  • Fixed in Releases 2.0.0 added

#4 Updated by Jeremy Lenz 12 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF