Project

General

Profile

Actions

Bug #27862

closed

Repository Autocomplete broken for Container Image Tags

Added by Jonathon Turel about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Container
Target version:
Difficulty:
easy
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

Found while reviewing https://github.com/Katello/katello/pull/8346/files

::Katello::DockerMetaTag.complete_for("repository=")
2019-09-16T20:19:41 [W|app|] DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s): "\"katello_repositories\".\"name\"". Non-attribute arg
uments will be disallowed in Rails 6.0. This method should not be called with user-provided values, such as request parameters or model attributes. Known-safe values can be passed by wrapping them in Arel.sql().
 (called from irb_binding at (irb):7)
Traceback (most recent call last):
        1: from (irb):7
ActiveRecord::StatementInvalid (PG::UndefinedColumn: ERROR:  column katello_repositories.name does not exist)
LINE 1: SELECT  DISTINCT "katello_repositories"."name" FROM "katello...
                         ^
: SELECT  DISTINCT "katello_repositories"."name" FROM "katello_repositories" ORDER BY "katello_repositories"."name" LIMIT $1

Reproducible in the UI through Content -> Container Image Tags and typing 'repository = ' in the search box

Actions #1

Updated by The Foreman Bot about 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Partha Aji
  • Pull request https://github.com/Katello/katello/pull/8346 added
Actions #2

Updated by Partha Aji about 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #3

Updated by Justin Sherrill about 5 years ago

  • Target version set to Katello 3.14.0
  • Triaged changed from No to Yes
Actions

Also available in: Atom PDF