Project

General

Profile

Actions

Bug #27865

closed

Previous definition and unused CBC ciphers

Added by Lukas Zapletal over 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Proxy plugin
Target version:
-
Difficulty:
Triaged:
No
Found in Releases:

Description

Dynflow plugin has a copy of file from core which issues warnings during startup:

/home/lzap/work/smart_proxy_dynflow/lib/smart_proxy_dynflow_core/webrick-patch.rb:3: warning: already initialized constant CIPHERS
/home/lzap/work/smart-proxy/lib/webrick-patch.rb:3: warning: previous definition of CIPHERS was here

Let's either drop it or fix it.

Also unused CBC ciphers can be now dropped.


Related issues 1 (0 open1 closed)

Related to Smart Proxy - Bug #27993: Remove unused CBC ciphers ClosedLukas ZapletalActions
Actions #1

Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/smart_proxy_dynflow/pull/65 added
Actions #2

Updated by Adam Ruzicka over 4 years ago

The issue description is not entirely correct. In production deployments, smart proxy dynflow runs as a separate process, completely outside of the smart proxy and it needs to have this patch. The issue you're describing happens when you run smart proxy dynflow core as part of the smart proxy process. I'd say the right solution would be to skip loading of the webrick patch if we're running in the smart proxy process.

Actions #3

Updated by Lukas Zapletal over 4 years ago

  • Related to Bug #27993: Remove unused CBC ciphers added
Actions #4

Updated by Lukas Zapletal over 4 years ago

  • Subject changed from Warning: previous definition of CIPHERS was here to Previous definition and unused CBC ciphers
  • Description updated (diff)
Actions #5

Updated by Anonymous over 4 years ago

  • Status changed from Ready For Testing to Closed
Actions #6

Updated by Adam Ruzicka over 4 years ago

  • Fixed in Releases smart_proxy_dynflow-0.2.5 added
Actions #7

Updated by Adam Ruzicka almost 4 years ago

  • Fixed in Releases smart_proxy_dynflow_core-0.2.4 added
  • Fixed in Releases deleted (smart_proxy_dynflow-0.2.5)
Actions

Also available in: Atom PDF