Project

General

Profile

Bug #27865

Previous definition and unused CBC ciphers

Added by Lukas Zapletal 9 months ago. Updated 23 days ago.

Status:
Closed
Priority:
Normal
Category:
Proxy plugin
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

Dynflow plugin has a copy of file from core which issues warnings during startup:

/home/lzap/work/smart_proxy_dynflow/lib/smart_proxy_dynflow_core/webrick-patch.rb:3: warning: already initialized constant CIPHERS
/home/lzap/work/smart-proxy/lib/webrick-patch.rb:3: warning: previous definition of CIPHERS was here

Let's either drop it or fix it.

Also unused CBC ciphers can be now dropped.


Related issues

Related to Smart Proxy - Bug #27993: Remove unused CBC ciphers Closed

Associated revisions

Revision c644eb44 (diff)
Added by Lukas Zapletal 8 months ago

Fixes #27865 - unused CBC ciphers and warning

History

#1 Updated by The Foreman Bot 9 months ago

  • Assignee set to Lukas Zapletal
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart_proxy_dynflow/pull/65 added

#2 Updated by Adam Ruzicka 9 months ago

The issue description is not entirely correct. In production deployments, smart proxy dynflow runs as a separate process, completely outside of the smart proxy and it needs to have this patch. The issue you're describing happens when you run smart proxy dynflow core as part of the smart proxy process. I'd say the right solution would be to skip loading of the webrick patch if we're running in the smart proxy process.

#3 Updated by Lukas Zapletal 8 months ago

  • Related to Bug #27993: Remove unused CBC ciphers added

#4 Updated by Lukas Zapletal 8 months ago

  • Description updated (diff)
  • Subject changed from Warning: previous definition of CIPHERS was here to Previous definition and unused CBC ciphers

#5 Updated by Anonymous 8 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by Adam Ruzicka 8 months ago

  • Fixed in Releases smart_proxy_dynflow-0.2.5 added

#7 Updated by Adam Ruzicka 23 days ago

  • Fixed in Releases smart_proxy_dynflow_core-0.2.4 added
  • Fixed in Releases deleted (smart_proxy_dynflow-0.2.5)

Also available in: Atom PDF