Project

General

Profile

Bug #27873

Put ngReact in the proper place

Added by Jonathon Turel over 2 years ago. Updated over 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Web UI
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

John found some quirks with our usage of ngReact1 and the suggestions for improvement are:

- move ngReact from 'devDependencies' to 'dependencies' in bower.json
- copy ngReact into engines/bastion/vendor/assets/javascripts/bastion/
- ngReact is present in package.json - determine if it can be removed since it's an angular dependency, not react

[1] https://gist.github.com/johnpmitsch/4f264d600f51444371f4d99ffef77cf2


Related issues

Related to Katello - Tracker #27127: Move bastion and angular pages into webpackNew

History

#1 Updated by John Mitsch over 2 years ago

  • Related to Tracker #27127: Move bastion and angular pages into webpack added

#2 Updated by Justin Sherrill over 2 years ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.14.0
  • Category set to Web UI

#3 Updated by Jonathon Turel over 2 years ago

  • Target version changed from Katello 3.14.0 to Katello Backlog

Also available in: Atom PDF