Project

General

Custom queries

Profile

Actions
Copy link

Bug #28086

closed

Show error on invalid oidc issuer

Added by Nikhil Kathole over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Rahul Bajaj
Category:
Authentication
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
1772029
Pull request:
https://github.com/theforeman/foreman/pull/7190
Fixed in Releases:
1.24.0
Found in Releases:
1.24.0
Red Hat JIRA:

Description

If a valid issuer is not provided in the Foreman settings, then there is no way a user can understand why SSO failed.

The method `valid_issuer?` in openid_connect.rb checks if a valid issuer is present or not. But if that fails authentication
flow ends with a error saying `SSO failed` but does not specify why.

Steps:
1) Provide a wrong issuer in the Foreman settings.
2) Try to login via SSO.

Reproducible:
Always

Related issues 2 (1 open — 1 closed)

Related to Foreman - Feature #25809: Keycloak integration with ForemanClosedRahul BajajActions
Related to Foreman - Tracker #28345: SSO using OpenID ConnectNewRahul Bajaj

Actions
Actions
Copy link
 #1

Updated by Nikhil Kathole over 5 years ago

  • Category set to Authentication
Actions
Copy link
 #2

Updated by Marek Hulán over 5 years ago

Actions
Copy link
 #3

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7190 added
Actions
Copy link
 #4

Updated by The Foreman Bot over 5 years ago

  • Fixed in Releases 2.0.0 added
Actions
Copy link
 #5

Updated by Rahul Bajaj over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #6

Updated by Tomer Brisker over 5 years ago

  • Bugzilla link set to 1772029
Actions
Copy link
 #7

Updated by Tomer Brisker over 5 years ago

  • Fixed in Releases 1.24.0 added
  • Fixed in Releases deleted (2.0.0)
Actions
Copy link
 #8

Updated by Rahul Bajaj over 5 years ago

Actions
Copy link

Also available in: Atom PDF