Bug #28086
Show error on invalid oidc issuer
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Description
If a valid issuer is not provided in the Foreman settings, then there is no way a user can understand why SSO failed.
The method `valid_issuer?` in openid_connect.rb checks if a valid issuer is present or not. But if that fails authentication
flow ends with a error saying `SSO failed` but does not specify why.
Steps:
1) Provide a wrong issuer in the Foreman settings.
2) Try to login via SSO.
Reproducible:
Always
Related issues
Associated revisions
History
#1
Updated by Nikhil Kathole over 3 years ago
- Category set to Authentication
#2
Updated by Marek Hulán over 3 years ago
- Related to Feature #25809: Keycloak integration with Foreman added
#3
Updated by The Foreman Bot over 3 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/7190 added
#4
Updated by The Foreman Bot over 3 years ago
- Fixed in Releases 2.0.0 added
#5
Updated by Rahul Bajaj over 3 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset 029065bb7ea551408bc0ad4978e3b2e0de4fee28.
#6
Updated by Tomer Brisker over 3 years ago
- Bugzilla link set to 1772029
#7
Updated by Tomer Brisker over 3 years ago
- Fixed in Releases 1.24.0 added
- Fixed in Releases deleted (
2.0.0)
#8
Updated by Rahul Bajaj over 3 years ago
- Related to Tracker #28345: SSO using OpenID Connect added
Fixes #28086 - log error on invalid oidc issuer