Project

General

Profile

Bug #28124

Compute Resource create does not validates the zone name and creates the Compute Resource.

Added by Jitendra Yejare 9 months ago. Updated 6 months ago.

Status:
Closed
Priority:
High
Category:
Compute resources - GCE
Target version:
-

Description

Description:
-------------------
Compute Resource create does not validate the zone name for GCE CR and creates the Compute Resource. If I provide any non-existence zone name while creating the CR, it doesn't validate if the zone is present or not and creates the CR.

How Reproducible:
-------------------
Always

Steps:
-------------------
1. Create a Compute Resource from a hammer with the zone(that doesn't exist in GCE).

Actual Behavior:
-------------------
1. The Compute Resource is created
2. No sign of error or warning for non-existence of zone.

Expected Behavior:
--------------------
1. Either the Compute Resource should not be created or should show a warning and create CR with zone.

Associated revisions

Revision 0facb573 (diff)
Added by Kavita Gaikwad 6 months ago

Fixes #28124 - validate zone name in GCE along with key path

History

#1 Updated by Oleh Fedorenko 9 months ago

Hi Jitendra,

Is it possible to create a CR the same way but with direct API calls?

#2 Updated by Shira Maximov 8 months ago

  • Category changed from Compute resources to API
  • Project changed from Hammer CLI to Foreman

As we talked at the hammer grooming meeting, the validation should be in foreman core.

#3 Updated by Kavita Gaikwad 7 months ago

  • Assignee set to Kavita Gaikwad
  • Category changed from API to Compute resources - GCE

#4 Updated by Kavita Gaikwad 7 months ago

  • Subject changed from [Hammer] Compute Resource create does not validates the zone name and creates the Compute Resource. to Compute Resource create does not validates the zone name and creates the Compute Resource.

#5 Updated by Kavita Gaikwad 7 months ago

  • Bugzilla link set to 1785284

#6 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7324 added

#7 Updated by Kavita Gaikwad 6 months ago

  • Status changed from Ready For Testing to Closed

#8 Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/theforeman/foreman/pull/7333 added

#9 Updated by Tomer Brisker 6 months ago

  • Fixed in Releases 1.24.1, 2.0.0 added

Also available in: Atom PDF