Project

General

Profile

Actions
Copy link

Bug #2816

closed

diff view broken

Added by Anonymous over 11 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
Bugzilla link:
1271987
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

We're using

show_diff=true

on all our agents to see in the reports, what has changed. However, in 1.2 the behaviour is a bit weird.

The first click on "View Diff" results in a window, showing the diff, but the sizing is a bit off...

Clicking on any other "View Diff"s leads to an empty window.

Files

diff_1.png View diff_1.png 37.1 KB Anonymous, 07/22/2013 02:08 PM
diff_2.png View diff_2.png 15.6 KB Anonymous, 07/22/2013 02:08 PM
report.json report.json 19.2 KB Greg Sutcliffe, 10/17/2013 10:17 AM

Related issues 1 (0 open — 1 closed)

Related to Foreman - Bug #20710: View diff modal window overflowsClosedMarek Hulán08/23/2017Actions
Actions
Copy link
 #1

Updated by Sam Kottler over 11 years ago

  • Assignee set to Sam Kottler
  • Target version changed from 1.3.0 to 1.2.1
  • Difficulty set to easy
Actions
Copy link
 #2

Updated by Sam Kottler over 11 years ago

  • Status changed from New to Need more information

I've submitted a PR here to fix the issue in the first screenshot - https://github.com/theforeman/foreman/pull/810/.

I'm having trouble reproducing the second one. Just to confirm, you're seeing it when you view a diff, close the modal, and then open another diff? I'm on Chrome on Fedora 19 and the diff loads after a short wait. Which OS + browser do you use?

Actions
Copy link
 #3

Updated by Anonymous over 11 years ago

Hi,

Sam Kottler wrote:

I've submitted a PR here to fix the issue in the first screenshot - https://github.com/theforeman/foreman/pull/810/.

Hm, that doesn't help... Do I need to recompile anything?

I'm having trouble reproducing the second one. Just to confirm, you're seeing it when you view a diff, close the modal, and then open another diff?

Exactly.

I'm on Chrome on Fedora 19 and the diff loads after a short wait. Which OS + browser do you use?

Firefox on Debian/testing, but I had problems with Chrome also. I just tried Internet Explorer on Windows and that specfic problem is not showing up. Is there anything I can do to get more data potints?

Actions
Copy link
 #4

Updated by Dominic Cleal over 11 years ago

Michael Moll wrote:

Hi,

Sam Kottler wrote:

I've submitted a PR here to fix the issue in the first screenshot - https://github.com/theforeman/foreman/pull/810/.

Hm, that doesn't help... Do I need to recompile anything?

Run "rake assets:precompile" on a production installation. You may need to install "foreman-assets" first to get the dependencies.

Actions
Copy link
 #5

Updated by Anonymous over 11 years ago

After recompiling the assets the first issue is fixed while the second one is still there. It seems it occurs not for all diffs, but I can't see any specific reason for the failing ones.

Actions
Copy link
 #6

Updated by Sam Kottler over 11 years ago

Michael Moll wrote:

After recompiling the assets the first issue is fixed while the second one is still there. It seems it occurs not for all diffs, but I can't see any specific reason for the failing ones.

Okay great. Do you use a certain set of browser extensions on both Chrome + Firefox or is the issue occurring on a clean browser? Thanks for working through this with us.

Actions
Copy link
 #7

Updated by Anonymous over 11 years ago

I just tested it with Chrome (because that one has no extensions/plugins installed) and the same problem is occuring.

Actions
Copy link
 #8

Updated by Dominic Cleal over 11 years ago

Ditto, with a clean Firefox 21 profile. I think the key for the second issue is a report that causes horizontal scrolling in the diff display.

Actions
Copy link
 #9

Updated by Dominic Cleal over 11 years ago

  • Description updated (diff)
  • Target version changed from 1.2.1 to 1.2.2
Actions
Copy link
 #10

Updated by Dominic Cleal over 11 years ago

  • Status changed from Need more information to Ready For Testing
  • Target version changed from 1.2.2 to 1.3.0
Actions
Copy link
 #11

Updated by Ohad Levy over 11 years ago

am I reading this right ? the current PR only address the first issue and not the second?

If thats true, Sam, anything from your side, or should someone else revisit this?

thanks!

Actions
Copy link
 #12

Updated by Dominic Cleal over 11 years ago

  • Target version deleted (1.3.0)
Actions
Copy link
 #13

Updated by Greg Sutcliffe over 11 years ago

I saw this on my prod instance today. Interestingly, I don't think it's the over-wide diff that breaks the second view. Attached is a json dump of a report that broke it, for others to try. if you view the diff of `node.rb` then all diffs on the page break. If you view `auth.conf or `puppet.conf` then the diffs do not break, even though all 3 are over-wide.

Actions
Copy link
 #14

Updated by Dominic Cleal about 11 years ago

  • Category changed from Reporting to Web Interface
  • Status changed from Ready For Testing to New
  • Assignee deleted (Sam Kottler)
  • Difficulty deleted (easy)

Merging the first part of the bug fix, but leaving this ticket open as I believe the second part remains.

Actions
Copy link
 #15

Updated by T C over 10 years ago

The second part of the problem does remain. I've found that if you simply resize the window, everything will render correctly again. I'm not sure why this would be the case.

Actions
Copy link
 #16

Updated by Marek Hulán over 7 years ago

  • Status changed from New to Resolved
  • Bugzilla link set to 1271987

I haven't seen this for a long time, I think we can consider it resolved. Please reopen if you can still reproduce.

Actions
Copy link
 #17

Updated by Marek Hulán over 7 years ago

  • Related to Bug #20710: View diff modal window overflows added
Actions
Copy link

Also available in: Atom PDF