Feature #28161
Use ForemanModal for Bookmarks
Pull request:
Fixed in Releases:
Found in Releases:
Description
Refactor Bookmarks modal in Foreman to use the ForemanModal component. Also update the file structure. Depends on #27794
Associated revisions
Refs #28161: use selector to get search query
remove BOOKMARKS_SET_QUERY action
change id to searchBar
Refs #28161 - Bookmarks light refactoring
fix ForemanForm issue
Refs #28161 - fix autocomplete & formik bug
History
#1
Updated by Jeremy Lenz almost 3 years ago
- Assignee set to Jeremy Lenz
#2
Updated by The Foreman Bot over 2 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/7265 added
#3
Updated by The Foreman Bot over 2 years ago
- Fixed in Releases 2.1.0 added
#4
Updated by Jeremy Lenz over 2 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset dc123bb3d67b8e7971b253e22f0c40a749897b13.
Fixes #28161: Convert Bookmarks modal to ForemanModal
-Convert Bookmarks modal to ForemanModal
-Update integration tests to account for
ForemanModals in Redux store
-Update ForemanForm to throw non-form-related
JS errors and not swallow them (needed to do this
to discover why some tests were failing)
-Utilize useForemanModal hook for SearchModal
-Refactor SearchModal to add index.js so that
I could add the hook and still separate Redux
dispatches from presentational logic
-For BookmarkForm, pass down setModalClosed as prop
-Refactor BookmarkForm index.js to be explicit about
naming of mapStateToProps and mapDispatchToProps
-update snapshots after Patternfly updates
-rebase; remove old commits; update snapshots
-add Show Modal button to Storybook story
-refactor BookmarkForm inline function