Project

General

Profile

Feature #28161

Use ForemanModal for Bookmarks

Added by Jeremy Lenz 9 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Refactor Bookmarks modal in Foreman to use the ForemanModal component. Also update the file structure. Depends on #27794

Associated revisions

Revision dc123bb3 (diff)
Added by Jeremy Lenz 5 months ago

Fixes #28161: Convert Bookmarks modal to ForemanModal

-Convert Bookmarks modal to ForemanModal
-Update integration tests to account for
ForemanModals in Redux store
-Update ForemanForm to throw non-form-related
JS errors and not swallow them (needed to do this
to discover why some tests were failing)
-Utilize useForemanModal hook for SearchModal
-Refactor SearchModal to add index.js so that
I could add the hook and still separate Redux
dispatches from presentational logic
-For BookmarkForm, pass down setModalClosed as prop
-Refactor BookmarkForm index.js to be explicit about
naming of mapStateToProps and mapDispatchToProps
-update snapshots after Patternfly updates
-rebase; remove old commits; update snapshots
-add Show Modal button to Storybook story
-refactor BookmarkForm inline function

Revision af0de0b6 (diff)
Added by Jeremy Lenz 5 months ago

Refs #28161: use selector to get search query

remove BOOKMARKS_SET_QUERY action
change id to searchBar

Revision 4fdd032e (diff)
Added by Jeremy Lenz 5 months ago

Refs #28161 - Bookmarks light refactoring
fix ForemanForm issue

Revision 2cab1360 (diff)
Added by Jeremy Lenz 5 months ago

Refs #28161 - fix autocomplete & formik bug

History

#1 Updated by Jeremy Lenz 9 months ago

  • Assignee set to Jeremy Lenz

#2 Updated by The Foreman Bot 8 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7265 added

#3 Updated by The Foreman Bot 5 months ago

  • Fixed in Releases 2.1.0 added

#4 Updated by Jeremy Lenz 5 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF