Project

General

Profile

Actions

Bug #28189

closed

Manifest refresh redundantly calls Actions::Pulp::Repository::Refresh for all repos

Added by Partha Aji over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Subscriptions
Target version:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

When refreshing a manifest that updates few subscriptions or repos only (or performs no update at all, even), refreshing triggers updating of pulp importers of all RedHat repos in Default CV and Library. That redundantly slows down manifest refresh.

Version-Release number of selected component (if applicable):
Sat6.5

How reproducible:
100%

Steps to Reproduce:
1. Import a manifest, enable many repos, optionally synchronize them.
2. Refresh the manifest -twice in a row to be sure the 2nd does not update anything.
3. Check dynflow steps of the Manifest Refresh task

Actual results:
3. will show Actions::Pulp::Repository::Refresh steps for each and every RedHat repo enabled

Expected results:
3. to show those steps only for repos that were really affected by the manifest refresh

Additional info:
Particular upstream source code:

https://github.com/Katello/katello/blob/master/app/lib/actions/katello/organization/manifest_refresh.rb#L31-L36

triggers all the tasks Katello::Repository::RefreshRepository that is in fact Actions::Pulp::Repository::Refresh (cf. https://github.com/Katello/katello/blob/master/app/lib/actions/katello/repository/refresh_repository.rb).

Actions #1

Updated by Partha Aji over 4 years ago

  • Bugzilla link set to 1722768
Actions #2

Updated by The Foreman Bot over 4 years ago

  • Assignee set to Partha Aji
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/8415 added
Actions #3

Updated by Justin Sherrill over 4 years ago

  • Category set to Subscriptions
  • Target version set to Katello 3.15.0
  • Triaged changed from No to Yes
Actions #4

Updated by The Foreman Bot over 4 years ago

  • Fixed in Releases Katello 3.15.0 added
Actions #5

Updated by Partha Aji over 4 years ago

  • Status changed from Ready For Testing to Closed
Actions #6

Updated by Jonathon Turel over 4 years ago

  • Target version changed from Katello 3.15.0 to Katello 3.14.0
Actions

Also available in: Atom PDF