Project

General

Profile

Bug #28269

Remove translation from column table function

Added by Jeremy Lenz 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

The column should not do that because we have a script that searches for the __ in order to extract all the strings needs to be translated and upload them to the translation service.
All '__' instances should be hard coded strings and not variables so the script will only send strings to translate (and not variable name)
https://github.com/theforeman/foreman/blob/7f113cb4b781283ea7b50ee78d980414dd3bc741/webpack/assets/javascripts/react_app/components/common/table/schemaHelpers/column.js#L28

Associated revisions

Revision 85c0b771 (diff)
Added by Maria Agaphontzev 7 months ago

Fixes #28269 - Remove translation from table column

History

#1 Updated by Maria Agaphontzev 7 months ago

  • Assignee set to Maria Agaphontzev
  • Category set to Web Interface

#2 Updated by The Foreman Bot 7 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7176 added

#3 Updated by The Foreman Bot 7 months ago

  • Fixed in Releases 2.0.0 added

#4 Updated by Maria Agaphontzev 7 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by The Foreman Bot 7 months ago

  • Pull request https://github.com/theforeman/foreman/pull/7154 added

Also available in: Atom PDF