Project

General

Profile

Bug #2828

Wrong/empty password for oVirt leads to an exception

Added by Lukas Zapletal about 5 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
easy
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Instead of nice red bubble, 401 nasty error is thrown.

Also, I was somehow able to create a compute resource with wrong password and it saved, but when I click on edit, 401 error. Not able to recover through the UI.

We should:

  • print nice error when 401
  • check username/password when saving (maybe this is generic issue)

Associated revisions

Revision 113ec278 (diff)
Added by Ido Kanner 7 months ago

Fixes #2828 - Report an error when trying to save ovirt resource

On both create and update, there was no exception handler to captured
given exception. That resulted in having an exception screen instead of
an error message.
The fix capture all of the given exceptions, and report them as an
error.

added capture for Exception

added capture for StandardError, after a comment i got from gh bot

History

#1 Updated by Lukas Zapletal about 5 years ago

  • Description updated (diff)
  • Target version deleted (1.3.0)

#2 Updated by The Foreman Bot 9 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5176 added

#3 Updated by Ido Kanner 9 months ago

  • Assignee set to Ido Kanner

#4 Updated by Tomer Brisker 7 months ago

  • Legacy Backlogs Release (now unused) set to 330

#5 Updated by Ido Kanner 7 months ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF