Project

General

Profile

Bug #28332

GET /api/provisioning_templates/:id returns `audit_comment: null`

Added by Evgeni Golov 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
API
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

(this also applies to config templates)

our templates (lol) for provisioning_templates and config_templates contain a reference to the audit_comment, but there is no such field in the model, so the api response always contains "audit_comment: null"

I think this field should be write only (when you create/update) a template, as it gets stored in the audits, not in the templates itself.


Related issues

Related to Foreman Remote Execution - Bug #28333: GET /api/job_templates/:id returns `audit_comment: null`Closed

Associated revisions

Revision fe373cb0 (diff)
Added by Evgeni Golov 6 months ago

Fixes #28332 - don't expose audit_comment in templates

History

#1 Updated by Evgeni Golov 7 months ago

  • Related to Bug #28333: GET /api/job_templates/:id returns `audit_comment: null` added

#2 Updated by The Foreman Bot 7 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7195 added

#3 Updated by The Foreman Bot 6 months ago

  • Fixed in Releases 2.0.0 added

#4 Updated by Evgeni Golov 6 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF