Project

General

Profile

Bug #28334

Change a documentation button entry for the /domains/help page to 4.4.7Networking

Added by Sergei Petrosian 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
Network
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

As can be seen from the grep command below, the "Provisioning" documentation button is used on two pages, on /hosts/help and /domains/help. It is fine for both cases, however, it is definitely better to create unique links for each page.

~~~
$ grep -R --include *.*rb "Provisioning\")%" foreman/
foreman/app/views/domains/welcome.html.erb: <p><%= link_to _('Learn more about this in the documentation.'), documentation_url("4.4Provisioning")%></p>
foreman/app/views/hosts/welcome.html.erb: <p><%= link_to _('Learn more about this in the documentation.'), documentation_url("4.4Provisioning")%></p>
~~
~

Lzap has suggested a perfect idea to change the documentation_url for /domains/help to 4.4.7Networking. This ensures that documentation buttons for pages on Configuring networking all lead to one place.

Associated revisions

Revision 878e140d (diff)
Added by Sergei Petrosian 4 months ago

Fixes #28334 - change documentation button for domains

Change documentation button for the /domains/help page to be the same as or subnets - 4.4.7Networking

History

#1 Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7196 added

#2 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 2.0.0 added

#3 Updated by Anonymous 4 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot 4 months ago

  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman/pull/7209 added

#5 Updated by Tomer Brisker 4 months ago

  • Category set to Network
  • Fixed in Releases 1.24.0 added
  • Fixed in Releases deleted (2.0.0)

Also available in: Atom PDF