Project

General

Profile

Bug #28356

Fix power host failure reducer

Added by Redmine Asana Bot 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Associated revisions

Revision 5d70ee6d (diff)
Added by Ron Lavi 11 months ago

Fixes #28356 - Fix host's power status failure

Revision 84cfe9bd (diff)
Added by Ron Lavi 11 months ago

Refs #28356 - revert api status code change

History

#1 Updated by Ron Lavi 11 months ago

  • Assignee set to Ron Lavi
  • Category set to JavaScript stack

#2 Updated by The Foreman Bot 11 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7210 added

#3 Updated by Ron Lavi 11 months ago

The bug I found is on the way we handle the fail response from the server.

The response returns status code: 200 instead of 500
Which leads the redux reducers to treat it as success.

It means that the failure reducer was never called, and it would fail if it was called because the server doesn't return the values that the reducer is expecting.

#4 Updated by The Foreman Bot 11 months ago

  • Fixed in Releases 2.0.0 added

#5 Updated by Ron Lavi 11 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by The Foreman Bot 11 months ago

  • Pull request https://github.com/theforeman/foreman/pull/7215 added

Also available in: Atom PDF