Project

General

Profile

Feature #28384

Web UI should not show "Full Trace" when someone provides invalid search input

Added by Dominik Matoulek 11 months ago. Updated about 10 hours ago.

Status:
Closed
Priority:
Normal
Category:
Search
Target version:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1767040

1). Proposed title of this feature request

Satellite web UI should not show "Full Trace" when someone provides invalid search input.

2). What is the nature and description of the request?

Currently when someone enters wrong input in search like ' https://satellite.example.com/templates/provisioning_templates?search=&page=1"taiyyib ' then it fails with error ' invalid value for Integer(): "1\"taiyyib" ' and provides option to check "Full trace"

In the "Full Trace" all the information related to installed gems and ruby package versions is available so it can be misused to find out possible security issues on the satellite server. This is concerning when the Satellite server is exposed over the internet.

Satellite web UI should not show the "Full Trace" error log when we provide any garbage value in page number-based search. It should throw a simple message like "invalid argument" or "Wrong input".

3). How would the customer like to achieve this? (List the functional requirements here)
Remove the stack trace ( "Full Trace") option and throw a simple message like "invalid argument" or "Wrong input"

4).Is there already an existing RFE upstream or in Red Hat Bugzilla?
No

5) . Does the customer have any specific timeline dependencies and which release would they like to target?
No

6). Is the sales team involved in this request and do they have any additional input?
No

7). Would the customer be able to assist in testing this functionality if implemented?
Yes


Related issues

Related to Installer - Feature #30569: Add migration to change logging patternReady For Testing

Associated revisions

Revision a7874f57 (diff)
Added by Dominik Matoulek 3 months ago

Fixes #28384 - Allow hiding stacktraces in the UI

Revision d5ae8681 (diff)
Added by Jonathon Turel 3 months ago

Refs #28384 - handle case when request ID is missing

Revision 4a5db964 (diff)
Added by Tomer Brisker about 10 hours ago

Refs #28384 - Use correct Foreman version in error log task

Looks like this was missed when updating the original PR for comments.

History

#1 Updated by The Foreman Bot 11 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7220 added

#2 Updated by The Foreman Bot 9 months ago

  • Assignee set to Dominik Matoulek

#3 Updated by The Foreman Bot 3 months ago

  • Fixed in Releases 2.2.0 added

#4 Updated by Dominik Matoulek 3 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Dominik Matoulek 3 months ago

  • Related to Feature #30569: Add migration to change logging pattern added

#6 Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman/pull/7882 added

#7 Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Triaged changed from No to Yes
  • Target version set to 2.2.0
  • Subject changed from Satellite web UI should not show "Full Trace" when someone provides invalid search input to Web UI should not show "Full Trace" when someone provides invalid search input

#8 Updated by The Foreman Bot about 2 months ago

  • Pull request https://github.com/theforeman/foreman/pull/7975 added

#9 Updated by The Foreman Bot about 10 hours ago

  • Pull request https://github.com/theforeman/foreman/pull/8109 added

Also available in: Atom PDF