Project

General

Profile

Bug #28391

Modal error after react-bootstrap upgrade

Added by Ron Lavi 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-

Description

After one of the latest patternfy-react version update, with `react-bootstrap` update, maybe https://github.com/patternfly/patternfly-react/pull/3249,
tests started to fail with the following error:
```
console.error node_modules/jest-prop-type-error/index.js:8
onMouseDownDialog
in div (created by CustomModalDialog)
in CustomModalDialog (created by Modal)
in Transition (created by Fade)
in Fade (created by DialogTransition)
in DialogTransition (created by Modal)
in RefHolder (created by Modal)
in div (created by Modal)
in Portal (created by Modal)
in Modal (created by Modal)
in Modal (created by DiffModal)
```
and the warning:
`Warning: Unknown event handler property `%s`. It will be ignored.%s`
maybe it is something about a naming convention, see: https://github.com/styled-components/styled-components/issues/2218#issuecomment-489661463

opened an issue to `react-bootstrap` - https://github.com/react-bootstrap/react-bootstrap/issues/4872
and an issue to patternfly: https://github.com/patternfly/patternfly-react/issues/3364

Associated revisions

Revision ae55b7ef (diff)
Added by Ron Lavi 6 months ago

Fixes #28391 - fix failing tests

After one of the latest patternfy-react version update, with `react-bootstrap`, tests are failing

Revision d5a35cd4 (diff)
Added by Ron Lavi 6 months ago

Refs #28391 - snapshots update PF 2.39.10

patternfly fixed their modal issue which broke our tests
updated the PF version in foreman-vendor-core
modal tests forward-ref snapshots need to be updated.

History

#1 Updated by The Foreman Bot 6 months ago

  • Assignee set to Ron Lavi
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7231 added

#2 Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/theforeman/foreman/pull/7193 added

#3 Updated by The Foreman Bot 6 months ago

  • Fixed in Releases 2.0.0 added

#4 Updated by Ron Lavi 6 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/theforeman/foreman/pull/7266 added

#6 Updated by Tomer Brisker 4 months ago

  • Category set to JavaScript stack

Also available in: Atom PDF