Bug #28391: Modal error after react-bootstrap upgrade - Foreman

Actions

Copy link

Bug #28391

closed

Modal error after react-bootstrap upgrade

Added by Ron Lavi over 4 years ago. Updated about 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ron Lavi

Category:

JavaScript stack

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/7231, https://github.com/theforeman/foreman/pull/7193, https://github.com/theforeman/foreman/pull/7266

Fixed in Releases:

2.0.0

Found in Releases:

Red Hat JIRA:

Description

After one of the latest patternfy-react version update, with `react-bootstrap` update, maybe https://github.com/patternfly/patternfly-react/pull/3249,
tests started to fail with the following error:
```
console.error node_modules/jest-prop-type-error/index.js:8
onMouseDownDialog
in div (created by CustomModalDialog)
in CustomModalDialog (created by Modal)
in Transition (created by Fade)
in Fade (created by DialogTransition)
in DialogTransition (created by Modal)
in RefHolder (created by Modal)
in div (created by Modal)
in Portal (created by Modal)
in Modal (created by Modal)
in Modal (created by DiffModal)
```
and the warning:
`Warning: Unknown event handler property `%s`. It will be ignored.%s`
maybe it is something about a naming convention, see: https://github.com/styled-components/styled-components/issues/2218#issuecomment-489661463