Project

General

Profile

Actions

Bug #28391

closed

Modal error after react-bootstrap upgrade

Added by Ron Lavi almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Fixed in Releases:
Found in Releases:

Description

After one of the latest patternfy-react version update, with `react-bootstrap` update, maybe https://github.com/patternfly/patternfly-react/pull/3249,
tests started to fail with the following error:
```
console.error node_modules/jest-prop-type-error/index.js:8
onMouseDownDialog
in div (created by CustomModalDialog)
in CustomModalDialog (created by Modal)
in Transition (created by Fade)
in Fade (created by DialogTransition)
in DialogTransition (created by Modal)
in RefHolder (created by Modal)
in div (created by Modal)
in Portal (created by Modal)
in Modal (created by Modal)
in Modal (created by DiffModal)
```
and the warning:
`Warning: Unknown event handler property `%s`. It will be ignored.%s`
maybe it is something about a naming convention, see: https://github.com/styled-components/styled-components/issues/2218#issuecomment-489661463

opened an issue to `react-bootstrap` - https://github.com/react-bootstrap/react-bootstrap/issues/4872
and an issue to patternfly: https://github.com/patternfly/patternfly-react/issues/3364

Actions #1

Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ron Lavi
  • Pull request https://github.com/theforeman/foreman/pull/7231 added
Actions #2

Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/7193 added
Actions #3

Updated by The Foreman Bot almost 4 years ago

  • Fixed in Releases 2.0.0 added
Actions #4

Updated by Ron Lavi almost 4 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/7266 added
Actions #6

Updated by Tomer Brisker almost 4 years ago

  • Category set to JavaScript stack
Actions

Also available in: Atom PDF