Project

General

Profile

Refactor #28425

Avoid the use of SETTINGS[:fqdn]

Added by Ewoud Kohl van Wijngaarden 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Branch:
Difficulty:
medium
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Currently SETTINGS[:fqdn] is used in two places:

https://github.com/Katello/katello/blob/d9f5d173cb8a604caae3ad20c3f237d06c0f846b/app/models/katello/glue/candlepin/repository.rb#L17-L22
https://github.com/Katello/katello/blob/d9f5d173cb8a604caae3ad20c3f237d06c0f846b/app/controllers/katello/api/rhsm/candlepin_proxies_controller.rb#L269 (and its test case)

The downside of this is the application is assuming the system hostname is also the service name. When running behind a load balancer a common pattern is app1.example.com and app2.example.com both serving app.example.com. Because of that Setting[:foreman_url] exists and should be relied on for the canonical Foreman URL.

Associated revisions

Revision 11f05ed4 (diff)
Added by Chris Roberts 5 months ago

Fixes #28425 - Change service name to Foreman URL

History

#1 Updated by Ewoud Kohl van Wijngaarden 6 months ago

  • Description updated (diff)

#2 Updated by Chris Roberts 6 months ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.15.0
  • Category set to 98

#3 Updated by Chris Roberts 5 months ago

  • Difficulty set to easy
  • Assignee set to Chris Roberts
  • Status changed from New to Assigned

#4 Updated by Chris Roberts 5 months ago

  • Difficulty changed from easy to medium
  • Found in Releases Katello 3.13.0 added
  • Found in Releases deleted (Katello 3.15.0)

#5 Updated by The Foreman Bot 5 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/8528 added

#6 Updated by The Foreman Bot 5 months ago

  • Fixed in Releases Katello 3.16.0 added

#7 Updated by Chris Roberts 5 months ago

  • Status changed from Ready For Testing to Closed

#8 Updated by Chris Roberts 5 months ago

  • Fixed in Releases Katello 3.15.0 added
  • Fixed in Releases deleted (Katello 3.16.0)

Also available in: Atom PDF