Refactor #28425: Avoid the use of SETTINGS[:fqdn] - Katello - Foreman

Actions

Copy link

Refactor #28425

closed

Avoid the use of SETTINGS[:fqdn]

Added by Ewoud Kohl van Wijngaarden about 5 years ago. Updated almost 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Chris Roberts

Category:

Target version:

Katello 3.15.0

Branch:

Difficulty:

medium

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/Katello/katello/pull/8528

Fixed in Releases:

Katello 3.15.0

Found in Releases:

Katello 3.13.0

Red Hat JIRA:

Description

Currently SETTINGS[:fqdn] is used in two places:

https://github.com/Katello/katello/blob/d9f5d173cb8a604caae3ad20c3f237d06c0f846b/app/models/katello/glue/candlepin/repository.rb#L17-L22
https://github.com/Katello/katello/blob/d9f5d173cb8a604caae3ad20c3f237d06c0f846b/app/controllers/katello/api/rhsm/candlepin_proxies_controller.rb#L269 (and its test case)

The downside of this is the application is assuming the system hostname is also the service name. When running behind a load balancer a common pattern is app1.example.com and app2.example.com both serving app.example.com. Because of that Setting[:foreman_url] exists and should be relied on for the canonical Foreman URL.