Project

General

Profile

Refactor #28426

support mocha >= 1.10

Added by Anonymous 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Tests
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

mocha 1.10 breaks tests:

[2019-12-04T18:22:37.551Z] ===============================================================================
[2019-12-04T18:22:37.551Z] Failure: test_choose_protocol_and_fetch_wget_with_read_timeout(TftpTest):
[2019-12-04T18:22:37.551Z]   unexpected invocation: #<Mock:start>.start()
[2019-12-04T18:22:37.551Z]   satisfied expectations:
[2019-12-04T18:22:37.551Z]   - expected exactly once, invoked once: Proxy::HttpDownload.new("https://proxy.test", "/destination", "1000", 10, 10)
[2019-12-04T18:22:37.551Z] /home/jenkins/workspace/smart-proxy-develop-source-release/modules/tftp/server.rb:160:in `choose_protocol_and_fetch'
[2019-12-04T18:22:37.551Z] /home/jenkins/workspace/smart-proxy-develop-source-release/test/tftp/tftp_test.rb:90:in `test_choose_protocol_and_fetch_wget_with_read_timeout'
[2019-12-04T18:22:37.551Z]      87:     ::Proxy::HttpDownload.expects(:new).returns(stub(:start)).
[2019-12-04T18:22:37.551Z]      88:       with(src, dst, tftp_read_timeout, tftp_connect_timeout, tftp_dns_timeout)
[2019-12-04T18:22:37.551Z]      89: 
[2019-12-04T18:22:37.551Z]   => 90:     Proxy::TFTP.choose_protocol_and_fetch src, dst
[2019-12-04T18:22:37.551Z]      91:   end
[2019-12-04T18:22:37.551Z]      92: 
[2019-12-04T18:22:37.551Z]      93:   def test_choose_protocol_and_fetch_nfs
[2019-12-04T18:22:37.551Z] ===============================================================================

[2019-12-04T18:22:37.551Z] ===============================================================================
[2019-12-04T18:22:37.551Z] Failure: test_choose_protocol_and_fetch_wget_with_timeouts(TftpTest):
[2019-12-04T18:22:37.551Z]   unexpected invocation: #<Mock:start>.start()
[2019-12-04T18:22:37.551Z]   satisfied expectations:
[2019-12-04T18:22:37.551Z]   - expected exactly once, invoked once: Proxy::HttpDownload.new("https://proxy.test", "/destination", "1000", "40", "14300")
[2019-12-04T18:22:37.551Z] /home/jenkins/workspace/smart-proxy-develop-source-release/modules/tftp/server.rb:160:in `choose_protocol_and_fetch'
[2019-12-04T18:22:37.551Z] /home/jenkins/workspace/smart-proxy-develop-source-release/test/tftp/tftp_test.rb:75:in `test_choose_protocol_and_fetch_wget_with_timeouts'
[2019-12-04T18:22:37.551Z]      72:     ::Proxy::HttpDownload.expects(:new).returns(stub(:start)).
[2019-12-04T18:22:37.551Z]      73:       with(src, dst, tftp_read_timeout, tftp_connect_timeout, tftp_dns_timeout)
[2019-12-04T18:22:37.551Z]      74: 
[2019-12-04T18:22:37.551Z]   => 75:     Proxy::TFTP.choose_protocol_and_fetch src, dst
[2019-12-04T18:22:37.551Z]      76:   end
[2019-12-04T18:22:37.551Z]      77: 
[2019-12-04T18:22:37.551Z]      78:   def test_choose_protocol_and_fetch_wget_with_read_timeout
[2019-12-04T18:22:37.551Z] ===============================================================================

Associated revisions

Revision 89a16ff8 (diff)
Added by Michael Moll 8 months ago

Refs #28426 - pin mocha

Revision 30937600 (diff)
Added by Michael Moll 8 months ago

Fixes #28426 - update mocha to 1.10

History

#1 Updated by The Foreman Bot 8 months ago

  • Assignee set to Anonymous
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/687 added

#2 Updated by The Foreman Bot 8 months ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/688 added

#3 Updated by The Foreman Bot 8 months ago

  • Fixed in Releases 2.0.0 added

#4 Updated by Anonymous 8 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF