Project

General

Profile

Actions
Copy link

Bug #28443

closed

ReactApp component fails with webpack-4

Added by Redmine Asana Bot almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Avi Sharvit
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/7234
Fixed in Releases:
2.0.0
Found in Releases:
Red Hat JIRA:

Description

Asana task assigned to Avi Sharvit

Since the Layout exported with wrappers, it fails when calling `Layout.propTypes.data`

```js
// Layout/index.js
export default withRouter(connect(mapStateToProps, mapDispatchToProps)(Layout));

// ReactApp.js
import Layout from '../components/Layout';

layout: Layout.propTypes.data,
```

Need to import the propTypes directly

Actions
Copy link
 #1

Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7234 added
Actions
Copy link
 #2

Updated by The Foreman Bot almost 5 years ago

  • Fixed in Releases 2.0.0 added
Actions
Copy link
 #3

Updated by Avi Sharvit almost 5 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #4

Updated by Tomer Brisker almost 5 years ago

  • Category set to JavaScript stack
Actions
Copy link

Also available in: Atom PDF