Project

General

Profile

Bug #28443

ReactApp component fails with webpack-4

Added by Redmine Asana Bot 8 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Asana task assigned to Avi Sharvit

Since the Layout exported with wrappers, it fails when calling `Layout.propTypes.data`

```js
// Layout/index.js
export default withRouter(connect(mapStateToProps, mapDispatchToProps)(Layout));

// ReactApp.js
import Layout from '../components/Layout';

layout: Layout.propTypes.data,
```

Need to import the propTypes directly

Associated revisions

Revision ec59833f (diff)
Added by Avi Sharvit 8 months ago

Fixes #28443 - use Layout.propTypes correctly

History

#1 Updated by The Foreman Bot 8 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7234 added

#2 Updated by The Foreman Bot 8 months ago

  • Fixed in Releases 2.0.0 added

#3 Updated by Avi Sharvit 8 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Tomer Brisker 6 months ago

  • Category set to JavaScript stack

Also available in: Atom PDF