Refactor #2845: Command's output definition shouldn't use formatting functions - Hammer CLI - Foreman

Actions

Copy link

Refactor #2845

closed

Command's output definition shouldn't use formatting functions

Added by Tomáš Strachota over 11 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Tomáš Strachota

Category:

Target version:

1.3.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

Team Backlog:

Fixed in Releases:

Found in Releases:

In Kanboard:

Red Hat JIRA:

Description

Formatting functions should be replaced with field type. The function spoils field's information forever. Eg. once datetime is formatted it can't be printed in different format. More flexible approach would be to set field type (to DateTimeField ind this case) and move the formatting logic to output adapters. The adapter then decides how it shoud be formatted. Eg. Json adapter prints more structured info vs. Table adapter tends to shorten things.