Project

General

Profile

Actions
Copy link

Refactor #28564

closed

improve fact cleanup performance

Added by Tomer Brisker almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomer Brisker
Category:
Facts
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/7288
Fixed in Releases:
1.24.2, 2.0.0
Found in Releases:
Red Hat JIRA:

Description

`delete_orphaned_facts` step is very slow, it is loading all fact names and checking if they have fact values associated with them, then trying to also delete fact values unnecessarily.

Related issues 2 (0 open — 2 closed)

Related to Foreman - Feature #25227: Foreman-rake facts:cleanup batch/rolling supportClosedLukas ZapletalActions
Related to Foreman - Bug #30028: foreman-rake facts:clean fails with foreign key constraint violationClosedTomer BriskerActions
Actions
Copy link
 #1

Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/7288 added
Actions
Copy link
 #2

Updated by Tomer Brisker almost 5 years ago

  • Related to Feature #25227: Foreman-rake facts:cleanup batch/rolling support added
Actions
Copy link
 #3

Updated by The Foreman Bot almost 5 years ago

  • Fixed in Releases 2.0.0 added
Actions
Copy link
 #4

Updated by Tomer Brisker almost 5 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #5

Updated by Tomer Brisker almost 5 years ago

  • Fixed in Releases 1.24.2 added
Actions
Copy link
 #6

Updated by Tomer Brisker about 3 years ago

  • Related to Bug #30028: foreman-rake facts:clean fails with foreign key constraint violation added
Actions
Copy link

Also available in: Atom PDF