Project

General

Profile

Actions
Copy link

Refactor #28598

closed

Refactor #28278: Remove smart variables

Refactor #28597: Remove VariableLookupKey model

Remove VariableLookupKey from tests

Added by Ori Rabin about 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Shira Maximov
Category:
Parameters
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/7565
Fixed in Releases:
2.1.0
Found in Releases:
Red Hat JIRA:

Description

When removing Smart Variables the model tests should be removed.

Some of the tests should be changed to Smart Class Parameters (if they are testing some joint logic and do not already have a duplicate test for Smart Class Parameters).
Tests that are relevant only for Smart Variables or have a duplicate on Class Parameters should be removed.

Actions
Copy link
 #1

Updated by Tomer Brisker about 5 years ago

  • Parent task changed from #28278 to #28597
Actions
Copy link
 #2

Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Shira Maximov
  • Pull request https://github.com/theforeman/foreman/pull/7565 added
Actions
Copy link
 #3

Updated by The Foreman Bot over 4 years ago

  • Fixed in Releases 2.1.0 added
Actions
Copy link
 #4

Updated by Shira Maximov over 4 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF