Project

General

Profile

Bug #28717

confusing output when the installer has finished

Added by Evgeni Golov 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
foreman-installer script
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

On latest nightly, when something goes wrong during the install, the output still contains two "Success" lines:

Preparing installation Done                                              
  Something went wrong! Check the log for ERROR-level output
  Success!
  * Foreman is running at https://centos7-fat.yatsu.example.com
      Initial credentials are admin / changeme
  Success!
  * Foreman Proxy is running at https://centos7-fat.yatsu.example.com:8443
  The full log is at /var/log/foreman-installer/foreman.log

Also in the success case, I think one "Success!" would be sufficient?

Preparing installation Done                                              
  Success!
  Success!
  * Foreman is running at https://centos7-fat.yatsu.example.com
      Initial credentials are admin / changeme
  Success!
  * Foreman Proxy is running at https://centos7-fat.yatsu.example.com:8443
  The full log is at /var/log/foreman-installer/foreman.log

Related issues

Related to Installer - Bug #28785: duplicate "Success!" message on Installer completionClosed

Associated revisions

Revision c884a607 (diff)
Added by Eric Helms 9 months ago

Fixes #28717: Don't repeat success or show success when failed

History

#1 Updated by The Foreman Bot 9 months ago

  • Assignee set to Eric Helms
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-installer/pull/448 added

#2 Updated by The Foreman Bot 9 months ago

  • Fixed in Releases 2.0.0 added

#3 Updated by Eric Helms 9 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Evgeni Golov 9 months ago

  • Related to Bug #28785: duplicate "Success!" message on Installer completion added

Also available in: Atom PDF