Project

General

Profile

Actions

Bug #28750

closed

Template controller name must be plural

Added by Oleh Fedorenko almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

Since we've got convention according to which all controller names should be pluralized, TemplateController should be renamed to TemplatesController.

Also, because of that some hammer commands (which rely on pluralized resources' names) may fail. For example, hammer template-input update --template-id 1 --name 'Organiztaion' --new-name 'Organization' will fail, since the resolving input's name to id cannot be performed.

Actions #1

Updated by The Foreman Bot almost 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_templates/pull/137 added
Actions #2

Updated by Oleh Fedorenko almost 5 years ago

  • Triaged changed from No to Yes

UPD:

To fix hammer related issue it is enough to change the resource id in the API documentation.

Actions #3

Updated by The Foreman Bot almost 5 years ago

  • Fixed in Releases added
Actions #4

Updated by Oleh Fedorenko almost 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Ondřej Pražák almost 5 years ago

  • Fixed in Releases foreman_templates 8.0.0 added
  • Fixed in Releases deleted ()
Actions

Also available in: Atom PDF