Project

General

Profile

Refactor #28821

Make react component registry more resiliant to duplication

Added by Tomer Brisker 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

it is possible in some cases plugins create a duplicate component registry or try to register a component that has already been registered. We should be more defensive about these situations.

Associated revisions

Revision 43dfbf08 (diff)
Added by Tomer Brisker 7 months ago

Fixes #28821 - Make component registry resiliant to duplication

Some plugins might create a new registry or try to register a component
that is already registered. This moved the actual registry to the window
object and makes the ComponentRegistry class an interface for it. It
also allows registering the same component multiple times without
erroring.

History

#1 Updated by The Foreman Bot 7 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7376 added

#2 Updated by The Foreman Bot 7 months ago

  • Fixed in Releases 2.0.0 added

#3 Updated by Tomer Brisker 7 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF