Project

General

Profile

Bug #28844

Plugin pages that use react component are broken in production

Added by Avi Sharvit 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

It happens because the redux state gets copied into plugins which create multiple instances of the redux store.
A solution might be to turn the store into a global singleton.

Associated revisions

Revision 200ffeab (diff)
Added by Avi Sharvit 4 months ago

Fixes #28844 - protect the state from duplication

Make the redux state resiliant to code duplication
by saving the state globally on the window object.

History

#1 Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7379 added

#2 Updated by The Foreman Bot 4 months ago

  • Fixed in Releases 2.0.0 added

#3 Updated by Avi Sharvit 4 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF